build!: upgrade reqwest to 0.13 - #102
Merged
Merged
Conversation
reqwest 0.13 renames the rustls-tls feature to rustls, switches the default TLS crypto provider from ring to aws-lc-rs, and splits form-encoded request bodies out into a dedicated `form` feature that was previously bundled for free. BREAKING CHANGE: the reqwest dependency is now 0.13. Any consumer that builds reqwest::Request/Response values to pass into cli_engine::transport::debug_log_reqwest_request/debug_log_reqwest_response, or otherwise names reqwest types alongside cli-engine's transport APIs, must upgrade to reqwest 0.13 in the same change.
There was a problem hiding this comment.
Pull request overview
This PR upgrades the cli-engine crate’s HTTP transport stack by moving from reqwest 0.12 to 0.13, aligning dependency features with reqwest’s 0.13 feature split/rename and updating the workspace lockfile accordingly.
Changes:
- Bump
reqwestto0.13and update enabled features (rustls-tls→rustls, addform). - Refresh
Cargo.lockto capture the new reqwest/rustls TLS dependency tree (including aws-lc-based rustls defaults).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cli-engine/Cargo.toml | Updates the reqwest dependency version and feature set used by cli-engine. |
| Cargo.lock | Records the updated transitive dependency graph from upgrading to reqwest 0.13.x (including new TLS/provider-related crates). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mguerrero3-godaddy
approved these changes
Aug 24, 2026
axburgess-godaddy
approved these changes
Aug 24, 2026
Merged
jpage-godaddy
pushed a commit
that referenced
this pull request
Aug 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>cli-engine: 0.9.0</summary> ## [0.9.0](cli-engine-v0.8.7...cli-engine-v0.9.0) (2026-08-24) ### ⚠ BREAKING CHANGES * **fs:** default macOS config dir to Application Support ([#100](#100)) * upgrade reqwest to 0.13 ([#102](#102)) ### Features * **error:** let DetailedError contribute structured next_actions to error envelopes ([#99](#99)) ([9c8988a](9c8988a)) ### Bug Fixes * **fs:** default macOS config dir to Application Support ([#100](#100)) ([a8a2291](a8a2291)) ### Build System * upgrade reqwest to 0.13 ([#102](#102)) ([3794ab7](3794ab7)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reqwestfrom 0.12.24 to 0.13, renaming therustls-tlsfeature torustls(0.13's default rustls provider is aws-lc-rs, replacing ring) and adding the newformfeature that 0.13 split out of core (previously bundled for free).Breaking change
Consumers that build
reqwest::Request/Responsevalues themselves and pass them intocli_engine::transport::debug_log_reqwest_request/debug_log_reqwest_response, or otherwise name reqwest types alongside cli-engine's transport APIs, must upgrade to reqwest 0.13 in the same change — the crate's public transport functions take reqwest types by reference, so 0.12 and 0.13 callers won't type-check against each other.Test plan
cargo build -p cli-enginecargo test -p cli-engine(286 unit + 43 integration/doctests, all passing)cargo clippy -p cli-engine --all-targets -- -D warningscargo fmt --checkgodaddy/cli's workspace (withdomains-clientbumped to progenitor 0.14 / reqwest 0.13 in the same change) and confirmed the full workspace builds clean