Avoid panicking if a bad regexp is returned after converting glob pattern to regexp#983
Open
rdelcampog wants to merge 1 commit intogo-rod:mainfrom
Open
Avoid panicking if a bad regexp is returned after converting glob pattern to regexp#983rdelcampog wants to merge 1 commit intogo-rod:mainfrom
rdelcampog wants to merge 1 commit intogo-rod:mainfrom
Conversation
…b pattern to regexp
codespearhead
suggested changes
Apr 5, 2024
ysmood
force-pushed
the
main
branch
2 times, most recently
from
5da0786 to
0c7bc12
Compare
ysmood
force-pushed
the
main
branch
7 times, most recently
from
834f2bf to
c42b414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #982
Development guide
Link
Test on local before making the PR