Repository navigation
fix(ios): label the Apple Pay total with the merchant name - #34
jkasprzyk17 wants to merge 1 commit into
Conversation
PassKit shows the last summary item as the grand total ("Pay <label>").
A one-item cart sent that item as the total ("Pay Coffee"), and a cart
with several items and no merchantName read "Pay Total".
Always append a total item, labelled with merchantName, falling back to
CFBundleDisplayName, then CFBundleName, so the sheet never reads
"Pay Total" or "Pay <item>".
Document merchantName for both platforms and set it in every example.
Closes #19
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
The Swift implementation satisfies the main behavior in #19. It always appends a total, skips blank merchantName values, uses CFBundleDisplayName and CFBundleName fallbacks, and avoids "Total"… |
Add an iOS XCTest target and automated tests for the summary-item builder. Cover one-item carts, multiple items, explicit merchantName, blank or missing merchantName, bundle-name fallbacks, and total type behavior. |
| Docstring Coverage | |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (12 skipped: 1… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title accurately describes the iOS Apple Pay total-labeling change and uses the required fix: prefix. It is 58 characters, which exceeds the ideal 50-character limit, but remains concise and descr… Description check The description clearly explains the Apple Pay total behavior, fallback logic, documentation updates, testing, risks, and scope. It is directly related to the changeset. Out of Scope Changes check The changed Swift code, changelog, JSDoc, README, documentation, and examples support the Apple Pay total-label objective in #19. The documentation about total item types clarifies behavior already de…Security Check No medium-, high-, or critical-severity vulnerability is introduced. The only security-relevant code change is in package/ios/HybridPaymentHandler.swift: it selects a display label from the request …Full details: Title check
-
Explanation
The title accurately describes the iOS Apple Pay total-labeling change and uses the required fix: prefix. It is 58 characters, which exceeds the ideal 50-character limit, but remains concise and descriptive.
Full details: Out of Scope Changes check
-
Explanation
The changed Swift code, changelog, JSDoc, README, documentation, and examples support the Apple Pay total-label objective in
#19. The documentation about total item types clarifies behavior already delivered in#28and remains related to the requested payment-summary change. No unrelated product behavior is shown in the reviewed changes.
Full details: Security Check
-
Explanation
No medium-, high-, or critical-severity vulnerability is introduced. The only security-relevant code change is in
package/ios/HybridPaymentHandler.swift: it selects a display label from the request merchant name or local bundle metadata and appends it toPKPaymentRequest.paymentSummaryItems. The label is passed to PassKit as UI text; it is not used in a shell, SQL, URL, file path, authorization, or deserialization sink. The existing amount validation still rejects invalid amounts and negative totals. The remaining changes are documentation or example configuration changes.
-
Full details: Linked Issues check
-
Explanation
The Swift implementation satisfies the main behavior in
#19. It always appends a total, skips blankmerchantNamevalues, usesCFBundleDisplayNameandCFBundleNamefallbacks, and avoids"Total"and the item label. The JSDoc and examples also match this behavior. The required XCTest coverage for the summary-item builder remains absent. The test plan marks it unchecked, and the repository contains no iOS XCTest target or test file.Resolution
Add an iOS XCTest target and automated tests for the summary-item builder. Cover one-item carts, multiple items, explicit
merchantName, blank or missingmerchantName, bundle-name fallbacks, and total type behavior.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 5 files. (12 skipped: 12 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This branch has not been deployed
1 participant
Summary
merchantName, also for a one-item cart. Before, a single item became the total ("Pay Coffee"), and a cart with several items and nomerchantNameread "Pay Total".merchantNameis missing or blank, the total uses the app's display name (CFBundleDisplayName, thenCFBundleName). No configuration produces "Pay Total" or "Pay " anymore.merchantNameJSDoc (it is not "primarily Google Pay"), document the total line, and setmerchantNamein every README/docs/example snippet. Examples that passed a "Total" item now pass a real line item.Test plan
cd package && bun run typecheck(pass)cd package && bun run lint(pass; changed files also pass--max-warnings 0)cd package && bun run test(7 suites, 89 tests pass)cd package && npx nitrogen(no diff)bun run docs:build(pass)cd example && npx expo prebuild && xcodebuildfor the iOS simulator (pass), then checked the Apple Pay sheet on an iPhone 17 Pro simulator (iOS 26.5):merchantName: button "Pay React Native Pay Demo, 19,99 US$"; summary "Custom Item 19,99", then the totalmerchantName: button "Pay example, 5,49 US$" (app display name); summary Coffee 4,99, Tax 0,50, then the total 5,49cd example && bunx expo run:android(not run: no Kotlin changes)Risk
merchantNamestays optional.Notes
pendingitem gets a.pendingtotal. On iOS, Apple Pay then hides the total amount and shows "Amount Pending" instead of "Pay " (checked on the simulator). Google Pay'sESTIMATEDstill shows the amount.Closes #19
Need help on this PR? Tag
@codesmith-botwith what you need.