Add Vue/Vuetify 3 compatibility to Echo Vue helpers - #72
Conversation
Depend on glue-viz/echo#72 for v-model:value support.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 97.69% 97.69%
=======================================
Files 28 28
Lines 4070 4071 +1
=======================================
+ Hits 3976 3977 +1
Misses 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM, just a minor suggestion for better test coverage.
There is no direct test here for the different vuetify versions, so the compatibility will need to be tested downstream, right? I checked locally for your glue-jupyter branch with ipyvuetify 3 and main with 1.19; everything looks fine there.
Since main so far is still using 1.x, maybe the docstring update should also be amended to say "Vue[tify] 1-2" or "Vue <= 2"?
Co-authored-by: Derek Homeier <dhomeie@gwdg.de>
bb05d95 to
bae3932
Compare
dhomeier
left a comment
There was a problem hiding this comment.
Thanks, looking good now!
Pull Request Template
Description
This PR adds Vue/Vuetify 3 compatibility Echo Vue helpers.