Skip to content

Add Vue/Vuetify 3 compatibility to Echo Vue helpers - #72

Open
mariobuikhuizen wants to merge 3 commits into
glue-viz:mainfrom
mariobuikhuizen:feat_add_vue3_support
Open

Add Vue/Vuetify 3 compatibility to Echo Vue helpers#72
mariobuikhuizen wants to merge 3 commits into
glue-viz:mainfrom
mariobuikhuizen:feat_add_vue3_support

Conversation

@mariobuikhuizen

Copy link
Copy Markdown

Pull Request Template

Description

This PR adds Vue/Vuetify 3 compatibility Echo Vue helpers.

mariobuikhuizen added a commit to mariobuikhuizen/glue-jupyter that referenced this pull request Aug 21, 2026
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.69%. Comparing base (a70a30b) to head (bae3932).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          28       28           
  Lines        4070     4071    +1     
=======================================
+ Hits         3976     3977    +1     
  Misses         94       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dhomeier dhomeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor suggestion for better test coverage.
There is no direct test here for the different vuetify versions, so the compatibility will need to be tested downstream, right? I checked locally for your glue-jupyter branch with ipyvuetify 3 and main with 1.19; everything looks fine there.
Since main so far is still using 1.x, maybe the docstring update should also be amended to say "Vue[tify] 1-2" or "Vue <= 2"?

Comment thread echo/vue/tests/test_connect.py Outdated
Co-authored-by: Derek Homeier <dhomeie@gwdg.de>

@dhomeier dhomeier left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looking good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants