Repository navigation
Pin certifi to an uncompromised version number. (3.x) - #1441
Merged
Merged
Conversation
derek-globus
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
October 22, 2026 20:15
kurtmckee
reviewed
Oct 22, 2026
Comment on lines
29
to
30
| # cryptography 3.4.0 is known-bugged, see: | ||
| # https://github.com/pyca/cryptography/issues/5756 |
Member
There was a problem hiding this comment.
It catches my eye that we're adding this pin for security reasons, but are not similarly conscientious about forcing upgrades to, say, cryptography.
Contributor
Author
There was a problem hiding this comment.
Open to further discussion, but (from my read of the issue) that's not a security issue, that's a crash-fail so I'd approach them with a different level of concern.
Not to say that we shouldn't necessarily apply a similar approach there, just that we definitely should apply it here.
kurtmckee
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Pin our certifi dependency requirement to 2026.10.19 or greater.
Why?
The trust store prior to this version has been compromised (more details)