Skip to content

Pin certifi to an uncompromised version number. (4.x) - #1440

Merged
derek-globus merged 2 commits into
globus:mainfrom
derek-globus:pin-certifi
Oct 22, 2026
Merged

derek-globus merged 2 commits into
globus:mainfrom
derek-globus:pin-certifi

Conversation

@derek-globus

Copy link
Copy Markdown
Contributor

What?

Pin our certifi dependency requirement to 2026.10.19 or greater.

Why?

The trust store prior to this version has been compromised (more details)

@derek-globus derek-globus changed the title Pin certifi to an uncompromised version number. Pin certifi to an uncompromised version number. (4.x) Oct 22, 2026
@codspeed

codspeed Bot commented Oct 22, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 12.16%

1 warning

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 17 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ test_deeply_nested_object_encoding[1w-5d] 157.8 µs 179.7 µs -12.16%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing derek-globus:pin-certifi (2c03555) with main (563a3da)

Open in CodSpeed

@derek-globus

Copy link
Copy Markdown
Contributor Author

This codspeed-flagged regression is on the order of 10s of microseconds; almost certainly noise given the scope of change.

image

@derek-globus
derek-globus merged commit 019fb42 into globus:main Oct 22, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants