Skip to content

Add signalTracker types#115

Merged
swsnr merged 2 commits into
gjsify:mainfrom
AmionSky:signalTracker
Jun 21, 2026
Merged

Add signalTracker types#115
swsnr merged 2 commits into
gjsify:mainfrom
AmionSky:signalTracker

Conversation

@AmionSky

Copy link
Copy Markdown
Contributor

No description provided.

@swsnr

swsnr commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

@AmionSky Since you've opened quite a few PRs over the last few days, I'm sorry but I can't help wondering whether you're actually using all these types in your extension(s)? Or are you just doing this for the sake of it? With LLM support perhaps?

@AmionSky

Copy link
Copy Markdown
Contributor Author

I'm working on an extension, and when I have to look through a gnome js file to understand how it actually works, I thought I might as well write the types for it.
And no LLMs.

@swsnr swsnr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New files that aren't re-exported through existing modules need to be added to exports in gnome-shell/package.json; otherwise they can't be imported from outside.

@AmionSky

Copy link
Copy Markdown
Contributor Author

I tried putting it below "./misc/signals" but when I run yarn build it moves it above it.

Also should I open a PR to add the files from my other PRs as well?

@swsnr

swsnr commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Also should I open a PR to add the files from my other PRs as well?

If there are any that aren't re-exported from other modules, then yes, sure.

@swsnr swsnr merged commit 37aef38 into gjsify:main Jun 21, 2026
1 check passed
@AmionSky

AmionSky commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

They are reexported, but when I ran yarn build it tried to add those other files as well to the package.json.

@swsnr

swsnr commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

@AmionSky Not sure I follow… could you describe exactly which command you ran and what happened precisely?

@AmionSky

Copy link
Copy Markdown
Contributor Author

@swsnr just yarn build and it automatically makes changes to the package.json and adds these:

    "./ui/overview": {
      "import": {
        "types": "./dist/ui/overview.d.ts",
        "default": "./dist/ui/overview.js"
      },
      "require": {
        "types": "./dist/ui/overview.d.ts",
        "default": "./dist/ui/overview.cjs"
      }
    },
    "./ui/overview/ambient": "./dist/ui/overview-ambient.d.ts",
    "./ui/overviewControls": {
      "import": {
        "types": "./dist/ui/overviewControls.d.ts",
        "default": "./dist/ui/overviewControls.js"
      },
      "require": {
        "types": "./dist/ui/overviewControls.d.ts",
        "default": "./dist/ui/overviewControls.cjs"
      }
    },
    "./ui/overviewControls/ambient": "./dist/ui/overviewControls-ambient.d.ts",
    "./ui/searchController": {
      "import": {
        "types": "./dist/ui/searchController.d.ts",
        "default": "./dist/ui/searchController.js"
      },
      "require": {
        "types": "./dist/ui/searchController.d.ts",
        "default": "./dist/ui/searchController.cjs"
      }
    },
    "./ui/searchController/ambient": "./dist/ui/searchController-ambient.d.ts",
    "./ui/workspaceThumbnail": {
      "import": {
        "types": "./dist/ui/workspaceThumbnail.d.ts",
        "default": "./dist/ui/workspaceThumbnail.js"
      },
      "require": {
        "types": "./dist/ui/workspaceThumbnail.d.ts",
        "default": "./dist/ui/workspaceThumbnail.cjs"
      }
    },
    "./ui/workspaceThumbnail/ambient": "./dist/ui/workspaceThumbnail-ambient.d.ts",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants