Stop provisioning GitHub integration-test credentials in CI - #21631
Merged
kylos101 merged 4 commits intoOct 2, 2026
Merged
Conversation
Co-authored-by: Codex <noreply@openai.com>
kylos101
commented
Oct 1, 2026
Comment on lines
-30
to
-35
| integration_test_username: | ||
| description: "The username for integration test" | ||
| required: true | ||
| integration_test_usertoken: | ||
| description: "The username for integration test" | ||
| required: true |
Contributor
Author
There was a problem hiding this comment.
Ditch the dependency on Github PAT
Co-authored-by: Codex <noreply@openai.com>
Co-authored-by: Codex <noreply@openai.com>
kylos101
had a problem deploying
to
branch-build
October 1, 2026 18:49 — with
GitHub Actions
Failure
Co-authored-by: Codex <noreply@openai.com>
kylos101
had a problem deploying
to
branch-build
October 1, 2026 19:55 — with
GitHub Actions
Failure
kbrennan-oai
approved these changes
Oct 2, 2026
kylos101
deleted the
kb/remove-github-user-token-from-integration-tests
branch
October 2, 2026 12:17
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stop provisioning GitHub test-user credentials in CI so integration runs do not depend on that credential. Preserve the original tests, helpers, and manual commands; tests requiring credentials skip when they are absent.
Add the missing username guard to the disk test and retain the Go 1.25 formatting fixes. CI validation also exposed a process-limit assertion that inspected only stdout: inspect stderr too, where bash writes fork diagnostics, while retaining the required error check.
Related Issue(s)
None.
How to test
84cabdac3: 32 passed, 13 expected skips, zero failures; both maintenance checks passed separately. Confirmed all ten GitHub-context-dependent workspace entry points skipped. Cgroup and process-limit checks passed.Documentation
No public documentation changes required. Integration test documentation is updated.
Preview status
Disposable validation previews were removed. Final cleanup passed.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold