Repository navigation
since view: list gate rows under the session they name (limit 74's open half) - #100
Open
githubscum wants to merge 2 commits into
Open
githubscum wants to merge 2 commits into
githubscum wants to merge 2 commits into
Conversation
A gated-action or policy-warn row whose own sessionId is a non-empty string now lands on that session's record. Absent, null, empty or non-string stays unattributed; egress rows always do; nothing is attributed by timestamp. didWork counts gate rows, so a session whose only record is a denial is listed. The sort falls back to the first gate row. An approvals-only window now prints. No zero count prints. The tally counts on a Map: 'constructor' printed garbage and '__proto__' vanished. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WO: WO-SINCE-ATTRIBUTE. Addresses: KNOWN-LIMITS 74's open half, and limit 35's closing note. Eval: none named. This is R1 legibility, not a v3 rung.
What changed
Since 2026-09-07 every
gated-actionrow has carried the session id the hook passed.sessions_sinceignored it and printed "Gate decisions carry no session id", which is false for new rows. A reader asking "what did that session get denied" was told the record could not say, when the record said.gated-actionorpolicy-warnrow whose ownsessionIdis a non-empty string goes on that session's record asdenials,approvalsorwarns.null, empty or non-string stays inunattributed.egress-eventalways does. Nothing is attributed by timestamp.gateline per session with attributed rows, and no zero counts.Four adjacent bugs, each probed:
constructorprintedconstructor xfunction Object() { [native code] }1and__proto__vanished from the tally. It counts on aMapnow. The first of those was already in the unattributed block on main.No file under the non-delegable core changed.
Tested
npm teston the committed tree: 1405 tests, 1399 pass, 0 fail, 6 skipped.excludeSessionIdbeside other sessions' rows, odd ids and odd action names. The two tally failures came from it, and the re-run came back clean.git merge-treeagainst KNOWN-LIMITS 76: three readers stop reporting a refused write as touched #98 and receipt-coverage re-derived from every append site; KNOWN-LIMITS 87: sent targets are plaintext #99: both conflict inKNOWN-LIMITS.md, in the managed pin block only. Whichever lands later re-stamps.src/views/since.js,src/mcp/server.jsandtest/since-view.test.jsauto-merge with KNOWN-LIMITS 76: three readers stop reporting a refused write as touched #98, andtest/since-view.test.jspasses on that merged tree, 20 of 20. The full suite was not run on it.What a reviewer should doubt
decisionkey would count as approved, the same split the unattributed list already uses. The gate only writesdeniedandapprovedtoday.warnsarray can be long in the MCP response. Those rows were already in the response, underunattributed.warns, and nothing here truncates them.sessions_since's tool description changed, so a client that fingerprints tool definitions will read it as changed (limit 41). A running MCP server keeps the old code until restart.docs/receipt-coverage.mdgoes stale. Its "unattributed" line on main, and receipt-coverage re-derived from every append site; KNOWN-LIMITS 87: sent targets are plaintext #99's "still prints the caveat" sentence, go false when this lands. Left alone on purpose, because receipt-coverage re-derived from every append site; KNOWN-LIMITS 87: sent targets are plaintext #99 rewrites that file. Whichever lands second should fix the sentence.🤖 Generated with Claude Code