Skip to content

Speed up Go CI and report daily validation failures - #20752

Open
pelikhan wants to merge 2 commits into
mainfrom
pelikhan/shared-test-performance
Open

pelikhan wants to merge 2 commits into
mainfrom
pelikhan/shared-test-performance

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Why

The core Go test job spent 9m35s running tests serially. Sixteen top-level scenarios taking at least 10 seconds each accounted for 4m28s of that execution time.

Changes

  • Partition core packages into four deterministic, disjoint shards while retaining storage test-name sharding.
  • Move those 16 slow CLI-build, fleet simulation, PostgreSQL integration, conformance, and benchmark scenarios out of PR and main-push runs using testing.Short(). Daily and manual runs retain full coverage, including the service-backed dashboard suite.
  • Extend the existing daily full-validation workflow to create or update one bot-owned failure issue with the latest revision, suite outcomes, and run/job links. Issue writes are restricted to the main-branch reporting job. Successful runs leave investigation issues open for human triage.

This intentionally trades exhaustive per-push coverage for faster feedback; the existing 06:37 UTC daily run remains the full-suite backstop. The 4m28s figure is historical test execution moved off the frequent path, not a measured end-to-end speedup for the new CI jobs.

Validation

  • 37 focused CI contract tests passed, including shard completeness, deterministic selection, test modes, issue deduplication, and API error propagation.
  • All 16 selected scenarios passed against disposable PostgreSQL in full mode and skipped in short mode.
  • Actionlint, ESLint, Go vet/format checks, CAO and Copilot type checks, and workflow compilation passed.

Shard core packages across four jobs and reserve the 16 slowest core scenarios for daily and manual runs. File or update a failure issue from daily full validation while preserving complete scheduled coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review November 13, 2026 03:56
@pelikhan
pelikhan requested a review from mnkiefer as a code owner November 13, 2026 03:56
Preserve main's zero-based core package sharding and stronger shard contract tests alongside daily-only slow tests and failure issue reporting.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant