Skip to content

Fix CI setup, stale contracts, and dashboard lifecycle regressions - #20749

Merged
pelikhan merged 2 commits into
mainfrom
pelikhan/ci-fixes-9cf
Nov 13, 2026
Merged

pelikhan merged 2 commits into
mainfrom
pelikhan/ci-fixes-9cf

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Recent CI runs fail because browser jobs lack PostgreSQL and several tests still assume retired discovery, materialization, and raw-shard contracts. This aligns those checks with the current production boundaries and fixes command terminals that remain labeled queued after execution starts.

Changes

  • Provision disposable PostgreSQL for sharded browser CI and use consolidated, relationship-valid canonical fixtures with retention-safe timestamps and explicit native ingestion for revision tests.
  • Align bootstrap and read-only credential checks with the installed-runtime setup boundary; keep attested runtime acquisition covered separately.
  • Deliver queued-to-running status frames through the existing worker transport without advancing output replay cursors or widening execution authority.
  • Handle dashboards without optional pages, update source-availability and responsive assertions, and inline compiled CSS to eliminate a render-blocking request.

Validation

  • All 321 dashboard browser tests pass, including desktop/mobile PostgreSQL canvas and query-editor flows.
  • Dashboard unit suite: 3,883 passed, one pre-existing skip. Root integration contracts: 300 passed.
  • Bootstrap integration, native runtime tests, PostgreSQL queue tests, and all server-backed dashboard page checks pass.
  • Root/dashboard lint and type checks, 79 workflow compilations, documentation build, and the mobile DOM-budget check pass.

Remaining failure

This PR is intentionally a draft and does not make every CI gate green. Lighthouse mobile cold-load LCP remains approximately 2,551 ms against the unchanged 2,500 ms budget. Inline CSS resolves the observed first-contentful-paint failures; ineffective sprite, priority, and image-preload experiments were removed. Performance thresholds have not been relaxed.

Desktop and mobile screenshots from the populated full-site browser tests are attached in a PR comment.

Restore PostgreSQL-backed browser CI, align canonical fixtures and bootstrap coverage with current runtime boundaries, and stream live command status through the worker. Inline startup styles to remove the blocking CSS request while preserving existing performance budgets.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan

Copy link
Copy Markdown
Collaborator Author

Populated full-site PostgreSQL canvas, captured by the passing browser suite. Desktop (1440px) and mobile (390px) command consoles preserve terminal output and display live execution status.

Populated desktop command console at 1440px

Populated mobile command console at 390px

@github-actions

Copy link
Copy Markdown
Contributor

GitHub Actions lint failures

Failed scanners: actionlint

Workflow run: https://github.com/githubnext/gh-cao/actions/runs/43360103601

Generated .lock.yml files were excluded.

@pelikhan
pelikhan marked this pull request as ready for review November 13, 2026 03:39
@pelikhan
pelikhan requested a review from mnkiefer as a code owner November 13, 2026 03:39
Resolve PostgreSQL service ports in the browser test step, where the job context is available, and guard against job-level placement in the workflow contract test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor
Dashboard dead views

Dead element views (0):
Dead dashboard pages (0):
Analyzed 8 element renderers and 74 dashboard pages across 1 dashboard.json file(s) from dashboard/site/src/components/ui-elements.js.

⚠️ This reachability report is informational and does not block the pull request.
🔎 View the workflow run and report artifact.

@pelikhan
pelikhan merged commit fa659ce into main Nov 13, 2026
64 of 65 checks passed
@pelikhan
pelikhan deleted the pelikhan/ci-fixes-9cf branch November 13, 2026 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant