Repository navigation
[self-care:server-go-logging] Extract operator config parsing in cao-dashboard with debug logging - #20743
Closed
mnkiefer wants to merge 2 commits into
Closed
[self-care:server-go-logging] Extract operator config parsing in cao-dashboard with debug logging#20743mnkiefer wants to merge 2 commits into
mnkiefer wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits
readOperatorConfiginserver/cmd/cao-dashboard/canvas.gointo file reading and a testableparseOperatorConfig, mirroring the existing canvas config structure, and addscao:clidebug logs for the disabled and loaded states. Behavior and error messages are unchanged.Action: Reviewer should confirm the diff is behavior-preserving and that
go -C server vet ./...andgo -C server test ./...pass in CI.Diagnostics and privacy
commandLog(cao:cli), off by default.Tests added
Real-file tests in
canvas_test.gofor: omitted path, valid file, missing file, and invalid documents (empty, non-JSON, wrong type). No mocks.Validation
gofmt,go -C server vet ./...,go -C server test ./...all pass locally.Control Plane