Repository navigation
Remove obsolete CAO materializer and retired CLI references - #20738
Merged
Merged
Conversation
Runtime packaging moves into scripts/build-cao-runtime.mjs. The installer no longer materializes the runtime; native gh cao setup/update stage the attested artifact. Drop the setup-cao-runtime action and local source materialization. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Document native acquisition as the compaction replacement and remove the obsolete local-source installation path from the architecture. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
November 13, 2026 00:05
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Workflow validator results
-
npm run test:unit: fail -
npm run test:integration: fail -
npm run test:load: pass -
agentic-workflows compile: pass (all workflows valid, no errors or warnings) -
npm run docs:build: pass
Unit test failures
Many canvas/dashboard tests (for example tests/unit/dashboard-bundled-resources.test.mjs:83, dashboard-canvas-go-host.test.mjs:27) fail with: Canvas tests require an explicitly configured disposable POSTGRES_URL. This looks environmental (no PostgreSQL provisioned in the validator run); confirm they pass in CI with POSTGRES_URL set.
Integration test failures
tests/integration/control-inventory-credentials.test.mjs:572(credential verification is opt-in and cannot reach the validation issue reporter):TypeError: Cannot read properties of undefined (reading 'if')at line 577.tests/integration/dashboard-inventory-ingestion.test.mjs:1:SyntaxError: The requested module '../../dashboard/report/inventory-sources.mjs' does not provide an export named 'discoverRepositories'. This is a code-level failure; restore the export or update the test/importers.
Generated by Workflow PR Validator for #20738 · copilot · auto (Claude Sonnet 5.5) · ~14 AIC · ⌖ ~1 AIC · ⊞ 9.3K
Use a relative archive filename from its staging directory so GNU tar does not interpret Windows drive letters as remote hosts. Extend producer regression coverage to enforce the portable invocation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep native runtime acquisition query arguments out of cmd.exe by restoring executable-first PATHEXT ordering. The existing gh.exe fixture forwards arguments directly to bash without shell query-string splitting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Normalize filesystem paths before resolving esbuild output dependencies and emitting web asset paths. Cover Windows separators, lazy/external imports, cyclic dependencies, and fail-closed missing chunks. Keep the recovery test lease valid through live-container assertions, then shorten it explicitly for the restart phase. Allow database and container setup before exercising the command timeout so all recovery scenarios reach their intended boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Dashboard dead viewsDead element views (0):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retired
activity/cao.mjsCLI left stale callers and documentation, while the JavaScript runtime materializer duplicated installation responsibilities now owned by nativegh caocommands.Approach
materialize-cao.mjsand thesetup-cao-runtimeaction; move artifact packaging, sealing, and validation into the runtime build script.gh cao setupandgh cao update. Bare installer runs install the control plane only; local source materialization is no longer supported.Historical audit text and the intentional retired-launcher test fixture retain legacy CLI references.
Validation
Passed CAO typecheck and lint, installer tests (108), workflow contract tests (315), runtime artifact and installation tests, Go CLI tests, simulator vet, ShellCheck at warning severity, workflow compilation (79 workflows), and documentation build.
Full unit validation is not green: environmental failures include missing disposable PostgreSQL configuration, macOS Bash lacking
mapfile, and temporary-directory cleanup errors. Representative failures also reproduce without these changes. Credential-dependent campaign lifecycle and opt-in simulator integration journeys were not run.