Repository navigation
Fix timestamptz precision in native Value hint retry_at - #20697
Merged
Merged
Conversation
PostgreSQL timestamptz stores microseconds and rounds, so a nanosecond retry time (Linux clocks) never round-trips. The fencing test failed deterministically on CI comparing RetryAt; fencing itself was correct. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestNativeValueHintsFenceConcurrentInvalidationAndAcknowledgementfails on Linux CI ("Go unit tests (storage, shard 2)") on both PRs and main, with "failed acquisition acknowledged dirty evidence".This is not a concurrency race. Fencing works correctly: the failing hint
{Dirty:17 Processed:16}is the expected state. The assertion that fails isRetryAt.Equal(now.Add(time.Hour)). PostgreSQLtimestamptzstores microseconds and rounds, while Go'stime.Now()on Linux carries nanoseconds, so the stored retry time never round-trips. macOS clocks are microsecond-resolution, which is why the test passes locally.Changes
CompleteValueHinttruncatesretry_atto microseconds before storing it, so callers get back exactly what they wrote (and rounding can never move it later).nowto microseconds, matching production callers. All assertions are unchanged.Validation
golang:1.27.3+ Postgres 16): the old code reproduces the exact CI error 5/5; the fixed code passes 5/5.go test ./internal/postgresx -run TestNativeValueHints -count=50 -racepasses.