Skip to content

Fix Workflow contracts CI after Activity runtime removal - #20695

Closed
pelikhan wants to merge 7 commits into
mainfrom
pelikhan/fix-ci-failures-294
Closed

pelikhan wants to merge 7 commits into
mainfrom
pelikhan/fix-ci-failures-294

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Fixes the failing Workflow contracts run on main (run 43253801007), caused by #20648, #20651 and #20690.

  • Unit contracts (all areas): release-schedule.test.mjs now belongs to the workflows area in scripts/run-unit-area.mjs.
  • Integration contracts:
    • dashboard-inventory-ingestion no longer imports the deleted JS discoverRepositories. Repository discovery now runs natively in Go, so the test passes discovered repositories as explicit inputs.
    • The credential-verification test now asserts that the removed report job stays absent.
  • Public installer integration: The test verifies only the remaining dashboard runtime bundle because the activity bundle was retired. The same change is applied to campaign-lifecycle.
  • GitHub issue GraphQL integration: Removed the job, which ran a test file that has been deleted, and dropped it from the CI-tier contract.

The CAO efficiency failure is an agent report_incomplete result (tracked in #20653), not a code failure.

- Assign release-schedule unit test to the workflows area
- Drop removed JS repository discovery from inventory ingestion test
- Assert the removed validation report job stays absent
- Verify only the remaining dashboard runtime bundle
- Remove the CI job for the deleted issueOrPullRequest test

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan requested a review from mnkiefer as a code owner November 12, 2026 16:18
pelikhan and others added 5 commits November 12, 2026 08:34
Use control.mjs control-settings instead of activity/control-settings.mjs,
drop the activity/cao.mjs smoke check, and assert only surviving runtime files.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The massive-scale stress test now normalizes synthetic shards in-process
through dashboard/report/normalized-payloads.mjs, the production module the
retired command wrapped. Also import the stat helper the test already used,
and drop the stale hash-payloads step from the Value event-ledger reference.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
PostgreSQL timestamptz stores microseconds and rounds, so a nanosecond
retry time (Linux clocks) never round-trips. The fencing test failed
deterministically on CI comparing RetryAt; fencing itself was correct.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…edundant fixtures

Since the SQLite removal, every testutil.Postgres fixture provisions a full
canonical store (~360 daily partitions, ~5s), pushing internal/server past
the 10m go test timeout. Provision one template database per test process
through the production store and clone it per test (CREATE DATABASE ...
TEMPLATE), falling back to a private schema when the role cannot create
databases. Reclaim databases left by exited processes.

Also share one app across TestSessionArchiveResponseClosesReader subtests
and stop re-executing repository queries already covered by the full
dashboard corpus test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The storage shard timeout log showed only the test running at the 10m
deadline, not which tests consumed the budget. Run Go unit tests with -v so
every shard log records per-test durations and the next slow shard can be
attributed directly.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan closed this Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant