Repository navigation
fix: review panel labels, fetching for Rebase, Push, and Create PR after a closed PR - #575
Merged
Merged
Conversation
…ter a closed PR - File headers name their group when a file is listed both committed and uncommitted. - The Diff header names the lane's base ref (origin/main), not the fork commit. - The Diff fetches the lane's remote base on open and every minute through a new `fetch` channel op, so Rebase appears; `changes` itself still never fetches. - Group totals with only binary files or summarized folders show a file count, not +0 -0. - Additions and deletions pluralize in labels. - The file tree and split mode stay as chosen when the file list changes. - Push asks the agent to push a branch its remote is missing commits from, without a PR. - Create PR returns after the branch's PR is closed, or merged with work since. Why: packages/channel/src/changes.ts#function fetchBase | fetching stays a separate op the Diff calls once a minute; the changes read polled every 2 s must never fetch Why: packages/ui/src/components/diff/diff-view.tsx#function DiffView | view choices (tree, mode) live outside the keyed content, which remounts whenever the file list changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the Review panel gaps from the Ace map (^684 ^706 ^688 ^693 ^687 ^708 ^710; Q221 answered "Add Push").
README.md Committed,README.md Uncommitted) when a file is listed in both. The Diff header names the lane's base ref (origin/main), not the fork commit's SHA (Changes.against).fetchchannel op fetches the lane's remote-tracking base; the Diff calls it on open and once a minute while visible and focused.changesstill never fetches. The Diff now publishes its polled changes, so Rebase reaches the header and sidebar without a reload.N files, not+0 -0.1 addition, 0 deletions).Push Nasks the agent to push (lane pushin a lane,git pushotherwise) when the branch has commits its remote lacks (Changes.ahead: past its upstream, or past the fork point of an unpushed lane with a remote). Works for non-GitHub remotes.Smoke-tested on a loopback host (port 4432, isolated home/config/keychain) with headless Playwright:
review/wavewith a committed and an uncommitted README edit, a binary file and a 150-file untracked folder: grouped headers,wave -> origin/main,Untracked 151 files,Push 1; the tree stayed open after a new file appeared.Rebase +2without a reload.lane pushto the bare remote and Push went away.fix-project-remove(merged fix(host): keep removing projects to the host's owner #571) with an edit: sidebar shows fix(host): keep removing projects to the host's owner #571 and Create PR (not clicked).The 15 drifted notes
lane checkstill lists are on files this PR doesn't touch.Built in Ace
No. Built with Claude Code as a fix-train worker against the Ace map, outside Ace (#5).