Repository navigation
fix(ui): put faces after the channel name and pin only in the context menu - #520
Merged
Merged
Conversation
… menu Sidebar rows reserved space at the right edge for the facepile and a hover pin button, so short names truncated with room to spare. The facepile now follows the name inside the row, the name alone shrinks when both don't fit, and pin and unpin live only in the row's context menu. Fixes #505 Why: packages/ui/src/components/session-item/session-item.tsx#function Presence | the facepile sits inside the row's button, so its trigger keeps an empty title or the row's summary tooltip covers the presence tooltip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidebar rows no longer hold space at the right edge for the facepile and a hover pin button.
pr-13/pr-17/pr-24padding are gone, along with the unusedSessionActionsandhasVisibleActions.hoverExpandrows, and lobby rows all render the same title line, so they all get the change.Presencetooltip still opens from the faces. Because the faces are now inside the row's button, the trigger has an emptytitle, so a row's summary tooltip can't cover the presence tooltip. A lane note records this.Checked in a temporary Vite preview in headless Chromium (not committed). It covered short and long names, 0 to 4 people (including +1 overflow and an away person), a selected row, lobby rows, and both the plain and
hoverExpandvariants, plus the presence tooltip and the context menu. Screenshot not attached becauseghcan't upload images.Fixes #505
Built in Ace
No — Claude Code subagent outside Ace, run by the lead during a batch of fixes.