feat(workflows): add plugin slots - #4352
Open
markuswondrak wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds opt-in plugin slots to workflows, enabling project overlays to replace upstream extension points safely.
Changes:
- Registers and validates the stateless
pluginstep. - Persists unfilled slots as skipped and rejects fan-out placement.
- Adds automated tests and user documentation.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/workflows/__init__.py |
Registers the plugin step. |
src/specify_cli/workflows/engine.py |
Validates plugin types and fan-out restrictions. |
src/specify_cli/workflows/steps/plugin/__init__.py |
Implements plugin-slot behavior. |
tests/workflows/test_plugin_step.py |
Tests validation, execution, overlays, and attribution. |
tests/unit/test_bundler_references.py |
Covers bundled plugin references. |
tests/test_workflows.py |
Updates built-in registry expectations. |
docs/reference/workflows.md |
Documents plugin-slot usage. |
workflows/README.md |
Adds the plugin step overview. |
workflows/PUBLISHING.md |
Adds plugin to publishing validation. |
workflows/ARCHITECTURE.md |
Updates workflow architecture documentation. |
spec/workflow_overlays/OVERLAY_TESTING_GUIDE.md |
Adds a manual validation walkthrough. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Assisted-by: GitHub Copilot (model: gpt-5.6-terra, autonomous)
markuswondrak
force-pushed
the
feat/workflow-plugin-slots
branch
from
August 27, 2026 08:23
e3b7f59 to
3247ceb
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Fan-out exclusion is not enforced when workflows execute without prior validation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 1
- Review effort level: Balanced
mnriem
requested changes
Sep 1, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please address Copilot feedback
added 2 commits
September 2, 2026 10:06
Mirror GateStep's inside_fan_out check so plugin slots inside fan-out templates fail at execution time, not only at static validation. This closes the gap when WorkflowEngine.execute() is called without prior validation. Assisted-by: opencode (model: qwen3.7-max, supervised)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the upstream opt-in plugin workflow slot described in Discussion #3473, building on the standalone WorkflowResolver introduced by #3557.
Validation
Scope
No new CLI verbs, PresetResolver changes, shared helper extraction, resolver/merge behavior changes, bundled workflow slot, or status-color change.
Posted on behalf of @markuswondrak by GitHub Copilot (model: gpt-5.6-terra, autonomous).