Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
GitHub App setup accepts bootstrap-secret submissions before Hub can authenticate someone through GitHub. Limit repeated submissions while preserving the existing generated-secret setup flow.
What changes
Use the existing shared-cache request limiter to admit 10 setup authorization attempts per minute per trusted source IP. Rejected secrets count, and changing browser sessions does not reset the allowance. Further attempts return HTTP 429 with the existing localized retry guidance and cannot authorize setup or create an audit record, even with the correct secret.
Keep setup reads, callbacks, installation, and bootstrap-secret strength rules unchanged. Document the allowance and its shared-storage and proxy requirements.
The complete local Hub check still reports an existing dependency-audit finding outside this change.
Created from a Slack conversation.