Skip to content

fix(build): reject persisted checkout credentials #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(build): reject persisted checkout credentials #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
692e789
fix(build): reject persisted checkout credentials
Copilot Oct 27, 2026
8c8fac2
refactor(build): run checkout guard with tsx
Copilot Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/actions-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ jobs:
node: [24, 26]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
persist-credentials: false
- uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0
with:
node-version: ${{ matrix.node }}
Expand Down
14 changes: 9 additions & 5 deletions actions/build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,19 @@ runs:
with:
node-version: 24

- name: Check required npm files and build script
run: node "$GITHUB_ACTION_PATH/scripts/validate-repository/index.mjs" --root "$GITHUB_WORKSPACE"
shell: bash

- name: Install browser-check dependencies
- name: Install action dependencies
run: npm ci --ignore-scripts --omit=dev
shell: bash
working-directory: ${{ github.action_path }}

- name: Check checkout credentials
run: '"$GITHUB_ACTION_PATH/node_modules/.bin/tsx" --tsconfig "$GITHUB_ACTION_PATH/tsconfig.json" "$GITHUB_ACTION_PATH/scripts/validate-checkout/index.ts" --root "$GITHUB_WORKSPACE"'
shell: bash

- name: Check required npm files and build script
run: node "$GITHUB_ACTION_PATH/scripts/validate-repository/index.mjs" --root "$GITHUB_WORKSPACE"
shell: bash

- name: Build prototype as a non-root user in a Node container
run: |
docker run --rm \
Expand Down
7 changes: 6 additions & 1 deletion actions/build/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,19 @@ import js from "@eslint/js"
import { defineConfig } from "eslint/config"
import prettier from "eslint-config-prettier"
import globals from "globals"
import tseslint from "typescript-eslint"

export default defineConfig(
{
ignores: ["node_modules/**", "test/fixture/dist/**"],
},
js.configs.recommended,
{
files: ["**/*.mjs"],
files: ["**/*.ts"],
extends: [tseslint.configs.recommended],
},
{
files: ["**/*.{mjs,ts}"],
languageOptions: {
globals: { ...globals.browser, ...globals.node },
},
Expand Down
Loading
Loading