Repository navigation
Conversation
IrynaKulakova
approved these changes
Oct 13, 2026
IrynaKulakova
left a comment
Contributor
There was a problem hiding this comment.
Reviewed commit 4dbf51a. No actionable findings: the merged_at fallback preserves explicit merged values and is shared by text and structured output. Local lint and tests could not run because the installed Go binaries fail with "Bad CPU type in executable"; this approval is based on code inspection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Correct
list_pull_requestsoutput for merged pull requests when the REST list endpoint omits themergedboolean. Use a nonzeromerged_atas a fallback while preserving an explicit boolean.Why
An agent listing closed PRs currently sees
merged: falseeven for merged changes, which can corrupt contribution summaries. The regression reproduces this from raw REST JSON at current main.Fixes #3467
What changed
merged.MCP impact
The existing
mergedoutput now correctly describes list entries. No input or output fields are added.Prompts tested (tool changes only)
Regression calls use
list_pull_requestswithowner,repo, andstate: "all", both with all fields and withfields: ["number", "merged", "merged_at"]. No natural-language model prompts were run.Security / limits
The conversion uses data already returned by the API and adds no requests.
Tool renaming
Lint & tests
go test -race -count=1 -json ./...passed on Go 1.26.8 / macOS arm64go vet ./...,go build ./...,go mod tidy -diffand documentation generation passedThe original regression fails before the fix and passes after it. The branch now normally merges main
e3809fe91c7546633241006bf0b91f23b2595e28, preserving the original history. The two-file contribution patch is byte-identical to the reviewed patch. The full race run produced 8,392 test/subtest pass events, not 8,392 independent test cases. An independent targeted race rerun of the merged-state regression also passednpm auditis not clean. The unchanged upstream lockfile has one existing advisory affecting three development-dependency package entries. This PR does not upgrade that dependency chain. The audit result is separate from the passing builds and testsNo other-platform local tests, live GitHub/provider calls, browser visual review or natural-language model prompts were run. Local results do not imply upstream CI success or approval of the new head
Docs
This corrects an existing field without changing the tool schema.