Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix source-level issues in github/gh-aw workflows
Require immutable gh-aw action-mode references
Sep 11, 2026
mnkiefer
marked this pull request as ready for review
September 11, 2026 08:41
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved setup pins can still produce malformed or fallback workflows, and resolution failures may be omitted from manifests.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enforces immutable full-SHA references for github/gh-aw-actions/*, addressing #60226.
Changes:
- Adds strict action-mode pin resolution and rejects mutable/short references.
- Expands SHA-resolution tests and cache-backed compilation coverage.
- Regenerates release workflow metadata and removes the stale setup pin.
File summaries
| File | Description |
|---|---|
pkg/workflow/action_reference.go |
Implements strict action-mode reference resolution. |
pkg/workflow/action_pins.go |
Adds strict pin-resolution helper. |
pkg/workflow/action_reference_test.go |
Tests full-SHA acceptance and rejection paths. |
pkg/workflow/compiler_custom_actions_test.go |
Tests cache-backed action-mode compilation. |
pkg/workflow/compiler_yaml_test.go |
Updates release metadata fixture. |
.github/aw/actions-lock.json |
Removes stale setup pin data. |
.github/workflows/release.lock.yml |
Regenerates the release workflow. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 3
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+79
to
+80
| actionRefLog.Printf("Action mode: refusing to emit mutable external actions repo reference: %s", remoteRef) | ||
| return "" |
Comment on lines
+361
to
+362
| pinData := *data | ||
| pinData.StrictMode = true |
| name: "release build should include version", | ||
| isRelease: true, | ||
| version: "v0.1.2", | ||
| version: "0123456789abcdef0123456789abcdef01234567", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerated
github/gh-aw-actionsworkflows could emit mutable action references, triggering zizmor findings such asunpinned-usesand stale SHA/version comments. Action mode should only generate secure-by-constructionuses:references.Action-mode pinning
github/gh-aw-actions/*references to resolve to full commit SHAs.Strict setup-action resolution
github/gh-aw-actions/setup.Tests and generated pin data
github/gh-aw-actions/setuppin data synced from the canonical action lock.Example generated reference: