Repository navigation
fix: repair Docker enclave smoke workflow compatibility - #10361
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The digest-qualified runtime container reference fails the pinned gateway’s schema validation, preventing startup.
1 open issue
What changed in this PR
Updates Docker enclave smoke compatibility without changing the enclave runtime or isolation policies.
Changes:
- Raises the build smoke’s Copilot CLI pin to
1.0.80. - Restores the static Issues server pin and clarifies numeric tool arguments.
- Adds compatibility, image-consistency, and postprocessor regression checks.
| File | Description |
|---|---|
scripts/ci/smoke-enclave-workflow.test.ts |
Adds compatibility and pinning checks. |
scripts/ci/apply-general-workflow-patches.ts |
Restores the static Issues server image. |
.github/workflows/smoke-enclave-issues-read.md |
Explains compatibility and numeric arguments. |
.github/workflows/smoke-enclave-issues-read.lock.yml |
Updates generated server references. |
.github/workflows/smoke-enclave-build-test.md |
Raises the Copilot CLI version. |
.github/workflows/smoke-enclave-build-test.lock.yml |
Synchronizes generated CLI references. |
Review effort: Max
Upgrade the static Issues smoke gateway to v0.4.36 so its schema accepts the immutable GitHub MCP server reference. Keep manifest, download, runtime, and cache pins aligned and cover old/new schema behavior without weakening approved integrity. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
Contributor
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
Collaborator
Author
|
@copilot address review feedback |
Update container image handling for mcpg v0.4.15 compatibility. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Keep the same immutable gateway pin in the static smoke postprocessor instead of the compiler-internal sandbox.mcp.version field. Preserve generated runtime behavior and metadata while allowing the required strict dry-run gate. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
Preserve the PR branch's runtime-image regression tests alongside the strict-preflight repair. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
Update the compatible markdown-it lock from 14.3.2 to 14.3.3. Raise the existing docs Vite override from 8.0.16 to the patched 8.1.6 release containing launch-editor 2.14.2, with npm-resolved bundler dependencies. Preserve the high/critical audit gates and avoid unrelated direct dependency changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
Contributor
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit fbc2a5d |
Resolve source and test conflicts by combining the immutable MCP compatibility pins and CLI version fix with main's host-owned enclave lifecycle and local AWF installation. Regenerate and postprocess affected smoke locks; retain main's public SHA-512 docs lock metadata and the patched dependency versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 89c6ca75-abc8-456b-847f-01055d487e63
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Repair confirmed Docker enclave smoke compatibility defects without waiting for #10353 or changing the enclave runtime:
1.0.34to1.0.80, above the generated installer's minimum1.0.35.v1.12.2@sha256:508a0857ec762b1ab1cece29193345b501fab1dd9d1228a7b617062954cecac6, consistently in manifest, download and runtime configuration.v0.4.36@sha256:b4d2856018959c798b3e3f81ae4ab5b275e06354e123e1f7971de931f2f450f2, containing the digest-reference schema fix from github/gh-aw-mcpg#15212.sandbox.mcp.version. Strict dry-run preflight now passes; normal runtime behavior is unchanged. Generated manifest/download/launch/version metadata and cache references remain consistent.issue_numberarguments and cover old/new schemas, malformed digests, v2-envelope rejection contracts, image consistency, static-only patching and idempotence.Primary
tools.github: false/network.allowed: [], enclaveapprovedintegrity,github/gh-awrepository restriction, two-tool allowlist, finite disclosure, credential exclusions and redaction remain intact. Dynamic workflow unchanged.Failure evidence
1.0.34.issue_readresponse envelope is filtered asissue:github/gh-aw#unknown; last-green run 38400460722 used the restored immutable v1.12.2 image with flat issue/comments responses.@sha256runtime reference. Gateway v0.4.36 addresses that exact schema defect without stripping the digest or relaxing policy.Workflow validation and dispatch
gh aw compile smoke-enclave-issues-read --dry-runpassed source validation, model checks and ShellCheck with no warnings. Diagnostic lock preserved separately; normal generated workflow behavior restored. Optional Docker scanners were not run.workflow_dispatchonlpcox-docker-enclave-smoke-fixesatccd9dc230dd114240a32dbd8df18351c1c35fa99. In progress when verified; success remains unverified. This predates the dependency-only commit below. No dynamic run or dispatch retry.Dependency audit repair
Dependency audit run 39509964735 failed both high/critical gates. User-requested commit
000143245111547c30ba5a764777c906829314e8repairs the affected trees without audit suppression:markdown-itlock 14.3.2 → 14.3.3, fixing GHSA-vfgh-jcmw-g37q and GHSA-gfr2-rv44-r23c without changing the direct markdownlint CLI version or root manifest.npm audit --package-lock-only --audit-level=high --jsoneach exit 0, reporting zero vulnerabilities at every severity.npm ci --ignore-scriptsand fullastro check && astro buildpass; Astro check reports zero errors/warnings/hints. Build has nonfatal chunk-size and missing i18n/404 content notices.Explicitly unresolved
Dynamic run 39426069533 remains unexplained: sanitized metadata establishes Copilot exit
1after about 92 seconds and wrapperexit=24, successful preflight and no OOM or invocation timeout. Stderr/diagnostics remain intentionally redacted. No speculative model, network, budget or runtime fix is included.Missing terminal safe outputs and audit/token records are downstream symptoms. This PR does not claim all three smokes are green.
Authored-source security overview