Migrate lifecycle readers to generated data (ADR 0004 phase 4, partial) by Copilot · Pull Request #10360 · github/gh-aw-firewall

Copilot · 2026-10-20T21:43:21Z

ADR 0004 phase 4 calls for shared lifecycle data, run-local overlays, and actual-harness eligibility. This PR addresses the compatibility-reader migration only; phase completion remains blocked on the companion compiler contract and eligibility integration.

Generated lifecycle readers
- Replace host availability/retirement tables and proxy retirement tables with generated projections.
- Limit general CLI support to exact Copilot records with supported, deployment-unscoped CLI availability.
Compatibility boundaries
- Preserve host trim/case/separator matching and proxy lowercase-only retirement matching.
- Preserve suggestion ties through generated ordering metadata, validated against canonical availability.
- Retain errors and replacement suggestions; exclude object-prototype properties from retirement lookup.
Regression coverage and handoff
- Add scope, suggestion-tie, staged-model exclusion, and isolated compiled/bundled/proxy-loading coverage.
- Document remaining overlay, companion-contract, harness-probing, and shared eligibility work.

No staged availability, pricing, reasoning, context, or translation changes are activated. No workflow/config keys are introduced.

Refs ADR 0004 phase 4: migrate lifecycle validation, overlays, and harness eligibility #10294; this partial migration must not close Phase 4.

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

4 open issues

compatibility.provenance is incorporated into latestTimestamp(...) before… · New
This test now imports a JSON file via ES import, which also requires resolveJsonModule in the TS… · New
Importing JSON in TypeScript requires resolveJsonModule (and sometimes esModuleInterop… · New
The membership check !['auto', ...supported].includes(id) rebuilds an array (and does an O(n)… · New

What changed in this PR

Migrates host CLI model validation and proxy retirement guard to consume generated lifecycle projections, while preserving legacy suggestion ordering and matching compat behavior as part of ADR 0004 phase 4 (partial).

Changes:

Replace hardcoded supported/retired model tables with generated projections and add generated suggestionOrder to preserve legacy suggestion ties.
Extend the model-information compiler to validate and emit compatibility suggestion-order metadata without letting it “author” availability.
Add regression tests for compatibility ordering, staged-model exclusion, proxy matching boundaries, and compiled/bundled loading.

File	Description
src/model-information.compat.generated.json	Adds generated `suggestionOrder` alongside supported/retired projections.
src/copilot-model.ts	Switches host model validation to generated lifecycle projections and ordered suggestions.
src/copilot-model.test.ts	Adds tests for suggestion tie ordering, staged exclusions, and prototype-key safety.
shared/model-information/sources/lifecycle-compatibility.json	Introduces maintained source for legacy suggestion ordering (ordering only).
scripts/model-information/compile.cjs	Emits/validates compatibility projection and bumps compiler version.
scripts/model-information/compile.test.ts	Adds compile-time tests for suggestion ordering, scope exclusions, bundling, and proxy guard isolation.
containers/api-proxy/guards/retired-model-guard.js	Switches proxy retirement mapping to generated JSON via `Map`.
containers/api-proxy/guards/retired-model-guard.test.js	Adds tests asserting lowercase-only exact-match retirement behavior.
shared/model-information/manifest.generated.json	Updates compiler version and includes new source file in manifest.
shared/model-information/{catalog,target,baseline-to-target}.generated.json	Bumps catalog revision to reflect new deterministic inputs.
docs/adr/0004-model-information-management.md	Documents partial phase 4 handoff and updated compiler version.

_{Review effort: Lite}

lpcox · 2026-10-20T22:42:56Z

@copilot address review feedback

Validate lifecycle compatibility metadata before calculating catalogue timestamps and reuse a Set for suggestion membership. Cover missing, invalid, and non-string timestamp metadata. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16e60324-9d5b-4e04-927c-d0487339e7b2

github-actions · 2026-10-20T23:32:24Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-10-20T23:32:43Z

Documentation Preview

Documentation has been built for this PR.

Download preview artifact

To view locally:

Download the docs-preview-pr-10360 artifact from the workflow run
Unzip and open index.html in your browser

Built from commit 03dc493

github-actions · 2026-10-20T23:39:22Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	93.44%	93.45%	📈 +0.01%
Statements	92.03%	92.04%	📈 +0.01%
Functions	91.21%	91.21%	➡️ +0.00%
Branches	86.10%	86.12%	📈 +0.02%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/nvx/one-shot-adapter.ts`	82.9% → 83.4% (+0.56%)	80.2% → 80.7% (+0.52%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-10-20T23:48:19Z

✅ Smoke Gemini completed. All facets verified. 💎

💎 Faceted by Smoke Gemini

github-actions · 2026-10-20T23:48:19Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-10-20T23:48:21Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-10-20T23:48:21Z

Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-10-20T23:48:21Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #10360

github-actions · 2026-10-20T23:48:21Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-10-20T23:48:22Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-20T23:48:22Z

✅ Smoke Claude passed

Generated by Smoke Claude for #10360

github-actions · 2026-10-20T23:48:23Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-10-20T23:48:23Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-10-20T23:48:24Z

✅ Security Guard completed successfully!

Security Guard

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Security Guard · haiku45 · 4.73 AIC · ⊞ 6.0K · ◷

Generated by Security Guard for #10360

github-actions · 2026-10-21T00:12:06Z

Chroot Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.15	Python 3.12.15	✅ YES
Node.js	v24.21.0	v2.98.0	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Result: FAILED. Node.js differs between host and chroot (chroot reports v2.98.0, which looks like a non-Node binary or a wrong version). The smoke-chroot label was not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:12:20Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

Smoke Codex

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Smoke Codex · gpt54 · 19.4 AIC · ⊞ 20.9K · ◷

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-10-21T00:12:40Z

@Copilot @lpcox

MCP connectivity: ✅
GitHub.com connectivity: ✅
File I/O test: ✅
BYOK inference: ✅

Running in direct BYOK mode (COPILOT_PROVIDER_API_KEY + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw)
Status: PASS

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:12:52Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	❌	not run	❌ FAIL
Bun	hono	❌	not run	❌ FAIL
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	not run	❌ FAIL
Deno	std	N/A	not run	❌ FAIL
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	1/1 pkg passed	✅ PASS
Go	env	✅	1/1 pkg passed	✅ PASS
Go	uuid	✅	1/1 pkg passed	✅ PASS
Java	gson	❌	not run	❌ FAIL
Java	caffeine	❌	not run	❌ FAIL
Node.js	clsx	✅	all passed	✅ PASS
Node.js	execa	✅	all passed	✅ PASS
Node.js	p-limit	✅	all passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 5/8 ecosystems passed — FAIL

All repos cloned successfully.

Failures

Bun / Deno: The install commands (curl ... | bash and curl ... | sh) were denied by the sandbox permission policy, so neither tool was installed and no tests ran.
Java: ~/.m2 is root-owned, so Maven failed with "Could not create local repository". After retrying with a writable local repo, Maven failed with InvalidAlgorithmParameterException: the trustAnchors parameter must be non-empty while downloading from Maven Central. Nothing was compiled or tested.
.NET: The first attempt failed because /run/user/1001 was missing. It passed after setting XDG_RUNTIME_DIR and TMPDIR to a writable path.

Generated by Build Test Suite for #10360 · copilot · auto · 23.4 AIC · ⊞ 12K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:13:03Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-21T00:13:09Z

@Copilot @lpcox
ci: replace retired gpt-5.4-mini with gpt-5.6-luna in test-model-routing
feat(router): ship the Go router image and remove the Python implementation
MCP connectivity: ❌ (invalid state parameter)
GitHub.com connectivity: ✅
File write/read test: ✅
BYOK inference test: ✅
Running in direct BYOK mode (AWF_AUTH_TYPE=github-oidc + AWF_AUTH_AZURE_* + COPILOT_PROVIDER_BASE_URL) via api-proxy → Azure OpenAI (Foundry, o4-mini-aw) authenticated via Microsoft Entra
Overall: FAIL

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:13:39Z

✅ Smoke Copilot BYOK AOAI (api-key) completed. Copilot AOAI BYOK (api-key) mode operational. 🔓

🔑 BYOK (AOAI api-key) report filed by Smoke Copilot BYOK AOAI (api-key)

github-actions · 2026-10-21T00:13:39Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #10360

github-actions · 2026-10-21T00:14:03Z

✅ Smoke Copilot BYOK AOAI (Entra) completed. Copilot AOAI BYOK (Entra) mode operational. 🔓

🪪 BYOK (AOAI Entra) report filed by Smoke Copilot BYOK AOAI (Entra)

github-actions · 2026-10-21T00:16:21Z

Smoke Test: Gemini Engine Validation

GitHub MCP Testing: ✅
- ci: replace retired gpt-5.4-mini with gpt-5.6-luna in test-model-routing
- feat(router): ship the Go router image and remove the Python implementation
GitHub.com Connectivity: ✅ (HTTP 200)
File Writing Testing: ✅
Bash Tool Testing: ✅

Overall status: PASS

💎 Faceted by Smoke Gemini
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:17:03Z

✅ Smoke Gemini completed. All facets verified. 💎

💎 Faceted by Smoke Gemini

github-actions · 2026-10-21T00:19:55Z

Cloud Hypervisor + Copilot smoke test

Merged PR lookup: PASS
github.com connectivity: PASS (HTTP 200)
File write/read: PASS
example.com blocked: PASS (HTTP 000)
Overall: PASS

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:20:17Z

Smoke Test: Claude Engine Validation

API status: ✅ PASS
gh check: ✅ PASS
File status: ✅ PASS

Overall result: PASS

Generated by Smoke Claude for #10360 · claude · haiku45 · 33.9 AIC · ⊞ 6.1K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:20:53Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed (api.github.com): 200
✅ Blocked (example.com): blocked
Overall: PASS — @Copilot

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:21:25Z

Smoke Test (Copilot)

GitHub MCP ✅ (latest PR: "feat(router): add opt-in OpenTelemetry traces and metrics")
github.com connectivity ✅ (200)
File write/read ✅

Overall: PASS — @Copilot, @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:21:35Z

Services smoke test: ✅ Redis PONG, ✅ pg_isready accepting connections, ✅ SELECT 1 → 1. Overall: PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:22:07Z

Smoke Test: Copilot BYOK (Direct) Mode

✅ PASS

Test Results:

GitHub MCP: ✅ (PR list returned 2 merged PRs)
github.com Connectivity: ✅ (HTTP 200)
File Write/Read: ✅ (smoke-test-copilot-byok.txt exists)
BYOK Inference: ✅ (agent → api-proxy sidecar → api.githubcopilot.com working)

Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY) with api-proxy credential injection

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:22:16Z

OTEL smoke test

✅ S1 Module loading: otel.js loads; exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled.
✅ S2 Tests: 3 OTEL suites, 68/68 passed.
✅ S3 Env forwarding: trace ID/parent span ID are forwarded in env-passthrough.ts and api-proxy-env-config.ts (plus OTLP vars).
✅ S4 Token tracker: onUsage hook is present in token-tracker-http.js.
✅ S5 Diagnostics: otel.jsonl has 1 record for this run.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-10-21T00:23:27Z

Smoke Test

ci: replace retired gpt-5.4-mini with gpt-5.6-luna in test-model-routing
feat(router): ship the Go router image and remove the Python implementation
GitHub reads ✅
Playwright ❌
File write/cat ✅
AWF build ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

Initial plan

890a98c

Copilot AI assigned Copilot and lpcox Oct 20, 2026

Copilot started work on behalf of lpcox October 20, 2026 21:44

View session

Copilot AI linked an issue Oct 20, 2026 that may be closed by this pull request

ADR 0004 phase 4: migrate lifecycle validation, overlays, and harness eligibility #10294

Open

1 of 10 tasks

refactor: migrate lifecycle readers to generated projections

87b3198

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Implement ADR 0004 phase 4 for lifecycle validation and overlays~~ Migrate lifecycle readers to generated data (ADR 0004 phase 4, partial) Oct 20, 2026

Copilot finished work on behalf of lpcox October 20, 2026 21:55

Copilot AI requested a review from lpcox October 20, 2026 21:55

lpcox marked this pull request as ready for review October 20, 2026 22:17

Copilot AI max review requested due to automatic review settings October 20, 2026 22:17

Copilot AI reviewed Oct 20, 2026

View reviewed changes

Comment thread scripts/model-information/compile.cjs

Comment thread scripts/model-information/compile.test.ts

Comment thread src/copilot-model.ts

Comment thread scripts/model-information/compile.cjs

lpcox added the ready-for-aw label Oct 20, 2026

lpcox deployed to aoai-model October 20, 2026 23:48 — with GitHub Actions Active

lpcox deployed to aoai-model October 21, 2026 00:12 — with GitHub Actions Active

lpcox deployed to aoai-model October 21, 2026 00:13 — with GitHub Actions Active

lpcox deployed to aoai-model October 21, 2026 00:14 — with GitHub Actions Active

github-actions Bot added the smoke-gemini label Oct 21, 2026

lpcox merged commit 69fd358 into main Oct 21, 2026
344 of 352 checks passed

lpcox deleted the copilot/adr-0004-phase-4-migrate-lifecycle-validation branch October 21, 2026 00:23

lpcox deployed to aoai-model October 21, 2026 00:25 — with GitHub Actions Active

Conversation

Copilot AI commented Oct 20, 2026 • edited by lpcox Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lpcox commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Documentation Preview

Uh oh!

github-actions Bot commented Oct 20, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Security Guard

Uh oh!

github-actions Bot commented Oct 21, 2026

Chroot Version Comparison

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Smoke Codex

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Oct 20, 2026 •

edited by lpcox

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 20, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading