Skip to content

fix: use Responses for Azure o4-mini smoke requests - #10355

Merged
lpcox merged 2 commits into
mainfrom
lpcox-azure-smoke-responses-fix
Oct 20, 2026
Merged

lpcox merged 2 commits into
mainfrom
lpcox-azure-smoke-responses-fix

Conversation

@lpcox

@lpcox lpcox commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #10343, squash-merged as a6e3ce9. Applies only the isolated fix from eb74199 on top of current main.

  • Set COPILOT_PROVIDER_WIRE_API=responses in the two Azure BYOK smoke sources and their already-regenerated v0.92.5 locks. Copilot's generic Chat Completions fallback sends temperature=0, which o4-mini rejects.
  • Preserve the o4-mini-aw deployment, workflow-scoped pricing, all budget/isolation limits, pins, and schedules.
  • Add two regression cases and document the explicit Responses selection.

Exact scope: six files, 26 additions and 2 deletions. No security mitigation changes are reintroduced.

Validation

  • npm test -- --runInBand scripts/ci/configure-aoai-smoke-pricing.test.ts scripts/ci/apply-general-workflow-patches.test.ts: build and all 29 tests passed.
  • Targeted ESLint passed with warnings only; Markdownlint and git diff --check passed.
  • Patch ID matches eb74199 exactly.
  • Prior investigation verified Copilot CLI 1.0.98 offline in Linux with no network: Chat Completions sends temperature=0 and receives 400; Responses preserves the deployment alias, omits temperature, and succeeds with valid SSE. Live Azure smoke results remain to be confirmed by CI.

Security Guard's separate 10/10 budget exhaustion is not addressed; no budgets or approval/ready-for-aw labels were changed.

Cherry-picked from eb74199.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 6b8c2bd8-a190-45f6-ad6f-d88a02662b4c
Copilot AI max review requested due to automatic review settings October 20, 2026 17:53
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Documentation Preview

Documentation has been built for this PR.

Download preview artifact

To view locally:

  1. Download the docs-preview-pr-10355 artifact from the workflow run
  2. Unzip and open index.html in your browser

Built from commit 1f0a2dc

@lpcox

lpcox commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

@copilot merge main and resolve conflicts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrow configuration change is consistent across sources, locks, tests, and documentation; live Azure validation remains pending CI.

No open issues 🎉

What changed in this PR

Switches the two Azure BYOK smoke workflows to Responses to avoid o4-mini rejecting Copilot’s default temperature=0.

Changes:

  • Sets Responses in both workflow sources and generated locks, preserving deployment, pricing, budgets, pins, and schedules.
  • Adds two regression cases and documents the protocol selection.
File Description
scripts/​ci/​configure-aoai-smoke-pricing.test.ts Checks Responses selection and deployment preservation.
docs/​api-proxy-sidecar.md Explains why Responses is required.
.github/​workflows/​smoke-copilot-byok-aoai-entra.md Selects Responses for Entra smoke requests.
.github/​workflows/​smoke-copilot-byok-aoai-entra.lock.yml Synchronizes the generated Entra workflow.
.github/​workflows/​smoke-copilot-byok-aoai-apikey.md Selects Responses for API-key smoke requests.
.github/​workflows/​smoke-copilot-byok-aoai-apikey.lock.yml Synchronizes the generated API-key workflow.

Review effort: Max

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 93.44% 93.44% ➡️ +0.00%
Statements 92.03% 92.03% ➡️ +0.00%
Functions 91.21% 91.21% ➡️ +0.00%
Branches 86.10% 86.10% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/enclave/host-executor-server.ts 91.0% → 91.0% (+0.00%) 89.7% → 90.0% (+0.29%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

…ponses-fix

# Conflicts:
#	.github/workflows/smoke-copilot-byok-aoai-apikey.lock.yml
#	.github/workflows/smoke-copilot-byok-aoai-entra.lock.yml

Copilot AI commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@copilot merge main and resolve conflicts

Merged main and resolved both lock-file conflicts. Merge commit: c3ac3cc.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

@lpcox
lpcox merged commit 910d534 into main Oct 20, 2026
30 checks passed
@lpcox
lpcox deleted the lpcox-azure-smoke-responses-fix branch October 20, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants