Repository navigation
fix: use Responses for Azure o4-mini smoke requests - #10355
Conversation
Cherry-picked from eb74199. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6b8c2bd8-a190-45f6-ad6f-d88a02662b4c
Documentation PreviewDocumentation has been built for this PR. To view locally:
Built from commit 1f0a2dc |
|
@copilot merge main and resolve conflicts |
There was a problem hiding this comment.
🟢 Approval recommended
The narrow configuration change is consistent across sources, locks, tests, and documentation; live Azure validation remains pending CI.
No open issues 🎉
What changed in this PR
Switches the two Azure BYOK smoke workflows to Responses to avoid o4-mini rejecting Copilot’s default temperature=0.
Changes:
- Sets Responses in both workflow sources and generated locks, preserving deployment, pricing, budgets, pins, and schedules.
- Adds two regression cases and documents the protocol selection.
| File | Description |
|---|---|
scripts/ci/configure-aoai-smoke-pricing.test.ts |
Checks Responses selection and deployment preservation. |
docs/api-proxy-sidecar.md |
Explains why Responses is required. |
.github/workflows/smoke-copilot-byok-aoai-entra.md |
Selects Responses for Entra smoke requests. |
.github/workflows/smoke-copilot-byok-aoai-entra.lock.yml |
Synchronizes the generated Entra workflow. |
.github/workflows/smoke-copilot-byok-aoai-apikey.md |
Selects Responses for API-key smoke requests. |
.github/workflows/smoke-copilot-byok-aoai-apikey.lock.yml |
Synchronizes the generated API-key workflow. |
Review effort: Max
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
…ponses-fix # Conflicts: # .github/workflows/smoke-copilot-byok-aoai-apikey.lock.yml # .github/workflows/smoke-copilot-byok-aoai-entra.lock.yml
Merged |
|
✅ Copilot review passed with no inline comments. @lpcox Add the |
Summary
Follow-up to #10343, squash-merged as a6e3ce9. Applies only the isolated fix from eb74199 on top of current
main.COPILOT_PROVIDER_WIRE_API=responsesin the two Azure BYOK smoke sources and their already-regenerated v0.92.5 locks. Copilot's generic Chat Completions fallback sendstemperature=0, which o4-mini rejects.o4-mini-awdeployment, workflow-scoped pricing, all budget/isolation limits, pins, and schedules.Exact scope: six files, 26 additions and 2 deletions. No security mitigation changes are reintroduced.
Validation
npm test -- --runInBand scripts/ci/configure-aoai-smoke-pricing.test.ts scripts/ci/apply-general-workflow-patches.test.ts: build and all 29 tests passed.git diff --checkpassed.Security Guard's separate 10/10 budget exhaustion is not addressed; no budgets or approval/ready-for-aw labels were changed.