Skip to content

Require Node.js 24.15 or later for book-app-web - #52

Merged
DanWahlin merged 1 commit into
mainfrom
danwahlin-dependabot-pr-review
Oct 25, 2026
Merged

DanWahlin merged 1 commit into
mainfrom
danwahlin-dependabot-pr-review

Conversation

@DanWahlin

@DanWahlin DanWahlin commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

Why

#47 updated jsdom to 30.1.3. jsdom 30 and some of its dependencies need Node.js ^22.22.2 || ^24.15.0 || >=26.0.0. The sample declared engines.node as >=24.0.0. Node 24.0 through 24.14 is therefore outside the supported range.

Changes

  • Set engines.node to >=24.15.0 in samples/book-app-web/package.json.
  • Set the same value in the root entry of samples/book-app-web/package-lock.json.
  • Update the minimum version in .github/copilot-instructions.md.

The course docs already say "current Node.js LTS". CI uses node-version: "24". Neither needs a change.

Validation

Verified at commit 81c759b96ac608d305d5c0ac2b37ce01bfc3eb32, which includes the merged Dependabot updates from main.

  • Node 24.22.1 is installed and is the local nvm default. This is the latest Node 24 release reported by nvm at the time of the check.
  • npm ci --no-fund --no-audit completes with no engine warnings.
  • npm test -- --run: all 4 tests pass.
  • npm run build: the TypeScript check and production build pass.
  • Book app web CI passes on this commit. CodeQL and license checks also pass.
  • Playwright checks pass in Chrome 156.0.8078.48 on both the dev server and the production preview. Each server was checked at 1280, 768, 375, and 320 pixels wide.
  • All 272 filter-state checks pass: mixed-case title and author searches, whitespace and punctuation, every genre/status combination, combined search and filters, empty results, and reset to all books. Every state checks the displayed book data and all five statistics, including unread favorites and average rating.
  • Keyboard search, forward and reverse tab order, control labels, named regions, empty-state announcements, responsive grid columns, and horizontal overflow checks pass.
  • Desktop and phone screenshots were inspected. The browser script, JSON results, screenshots, and local command logs are saved in the session artifacts.

Non-blocking observations

  • npm 11.19.1 reports an install-script approval warning for the optional macOS dependency fsevents@2.3.3. Its native module loads and exposes watch. No script-approval policy was changed.
  • The browser reports a 404 for /favicon.ico. The sample has no favicon. This existed before this PR. No JavaScript runtime exceptions or other browser warnings/errors were found in the checked flows.

jsdom 30 (from #47) requires Node.js ^24.15.0 on the 24 line. Update engines.node so npm reports an unsupported Node version clearly, and update the Copilot instructions to match.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI max review requested due to automatic review settings October 25, 2026 03:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The three consistent metadata and documentation changes address unsupported early Node 24 versions without changing application behavior.

No open issues 🎉

1 file not reviewed
  • samples/book-app-web/package-lock.json: Generated file
What changed in this PR

Raises the book-app-web sample’s minimum Node.js version to 24.15.0, matching jsdom 30’s requirement within the Node 24 release line.

Changes:

  • Updates the minimum version in the package manifest and lockfile.
  • Aligns contributor instructions without changing dependencies or application behavior.
File Description
samples/​book-app-web/​package.json Raises engines.node to >=24.15.0.
samples/​book-app-web/​package-lock.json Synchronizes the root Node.js requirement.
.github/​copilot-instructions.md Documents the updated minimum and its jsdom rationale.

Review effort: Max

@DanWahlin
DanWahlin merged commit f24b521 into main Oct 25, 2026
7 checks passed
@DanWahlin
DanWahlin deleted the danwahlin-dependabot-pr-review branch October 25, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants