Skip to content

Unified: Consider all class-like decls as static members in name binding #22963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 2 commits into from
Nov 2, 2026
+5 −1
Merged

Unified: Consider all class-like decls as static members in name binding #22963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14034ae
Unified: Add static name binding test for nested enum
hvitved Oct 30, 2026
5a28a4b
Unified: Consider all class-like decls as static members in name binding
hvitved Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion unified/ql/lib/codeql/unified/internal/NameBindingPlugin.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,8 @@ predicate isStaticMember(Member member) {
exists(ClassLikeDeclaration cls | cls.getAMember() = member |
not any(NameBindingPlugin p).isInstanceMember(cls, member) or
member instanceof ConstructorDeclaration or
member instanceof TypeAliasDeclaration
member instanceof TypeAliasDeclaration or
member instanceof ClassLikeDeclaration
)
or
member = any(TopLevel t).getBody().getAStmt()
Expand Down
3 changes: 3 additions & 0 deletions unified/ql/test/library-tests/static-name-binding/test.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@ class A {
}

typealias BAlias = B // $ access=A.B

enum Enum { case empty }
}

let x1: B = nil // $ access=top.B
let x2: A.B = nil // $ access=A access=A.B
let x3: A.B.C = nil // $ access=A access=A.B access=A.B.C
let x4: A.BAlias.C = nil // $ access=A access=A.BAlias access=A.B.C
let x5 = A.Enum.empty // $ access=A access=A.Enum access=A.Enum.empty

class D {
let x1: B = nil // $ access=top.B
Expand Down
Loading