Rust: Fix performance issue with additionalExternalFile#21671
Open
geoffw0 wants to merge 1 commit intogithub:mainfrom
Open
Rust: Fix performance issue with additionalExternalFile#21671geoffw0 wants to merge 1 commit intogithub:mainfrom
geoffw0 wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Rust CodeQL analysis performance by adjusting how File.fromSource() checks additionalExternalFile, addressing a regression introduced by the neutral models work (PR #21271).
Changes:
- Adds a
pragma[nomagic]wrapper predicate forgetRelativePath(). - Updates
fromSource()to call the wrapper when checkingadditionalExternalFile(...).
Show a summary per file
| File | Description |
|---|---|
| rust/ql/lib/codeql/files/FileSystem.qll | Adjusts File.fromSource() path lookup to avoid a performance regression during analysis. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix performance issue with
File.fromSourcesadditionalExternalFile.