C#: Replace CFG with the shared implementation#21565
Draft
aschackmull wants to merge 35 commits intogithub:mainfrom
Draft
C#: Replace CFG with the shared implementation#21565aschackmull wants to merge 35 commits intogithub:mainfrom
aschackmull wants to merge 35 commits intogithub:mainfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
csharp/ql/lib/semmle/code/csharp/dataflow/internal/rangeanalysis/SsaReadPositionSpecific.qll
Fixed
Show fixed
Hide fixed
csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll
Dismissed
Show dismissed
Hide dismissed
aschackmull
force-pushed
the
csharp/cfg2
branch
3 times, most recently
from
8dd66df to
da7e652
Compare
aschackmull
force-pushed
the
csharp/cfg2
branch
4 times, most recently
from
43b2a3c to
66ad21b
Compare
The additions are unintentional, but the fault lies with the shared SignAnalysis code. The removals are due to compile-time constant initializers no longer having CFG nodes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the C# libraries to use the new shared CFG library.
Several queries are impacted, but overall I'd say that it's generally increased precision.
The first few commits are preliminary setup tweaks. Then "C#: Replace CFG." is the big commit that deletes the old CFG and puts in the new instantiation of the shared libraries. And the several following commits then deal primarily with qltest fallout.