Skip to content

Collect complete upgrade changelog statements with shared filters - #479

Merged
jlitola merged 5 commits into
mainfrom
jlitola/upgrade-review-statements
Oct 15, 2026
Merged

jlitola merged 5 commits into
mainfrom
jlitola/upgrade-review-statements

Conversation

@jlitola

@jlitola jlitola commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Upgrade reviews now collect every matching parsed changelog statement, replacing the priority-ordered 50-item risk cap. CLI and MCP share source-ordered bullets with nearby links, backend-owned uncertainty and the changelog filter syntax. The default remains focused; --changes actionable|important|all / MCP changes limits statement evidence while whole-range counters still drive batch triage.

Compact batches fetch counters without statement or entry arrays. Detailed views collect 100-item pages; JSON includes full statement/context text, source positions and per-item provenance. Existing security, dependency and keyword evidence remain available.

JSON migration: changelog.riskItems becomes changelog.statements with effective selection, complete counts/items and per-version coverage. riskCoverage.itemsOmitted is removed. Both public artifacts have pending minor release fragments; production aggregate-schema availability is a prerequisite for release.

Validation:

  • 624 affected tests / 2,858 assertions passed initially; review closures passed124 focused cases and39 final core cases. Typecheck is clean.
  • Package builds/packed external-consumer validation, Biome and all four source/built CLI/MCP smoke modes passed. Full Linux/Windows suites and Node20/22/24/26 plus Bun compatibility checks are green in CI.
  • Built CLI/local MCP dev parity: both Express ranges, Biome, all filters and compact/detailed batches. Biome all875 statements collected in9requests.
  • Measured GraphQL complexity: maximum30-package JSON475, triage391, continuation88 (limit500).
  • Targeted agent workload succeeded with2 completed upgrade reviews. A post-review argument-wording rerun completed its7-package upgrade review, then timed out during broader research with no final. Traces/metrics inspected; no quality grading ran.

Review: internal preflight/correctness passes and external Opus review are clean. Round3 verified all sanitation, presentation, request ownership and test-coverage findings closed. The temporary implementation plan is retired; permanent docs and the backend supersession backlog retain relevant facts.

Dev totals (warm stored labels):

Range Parsed / focused Confident / uncertain action Confident / uncertain know No impact Classified versions
express 5.0.0..5.2.1 141 /15 0 /8 6 /1 126 4
express 4.19.2..4.21.2 57 /14 3 /4 7 /0 43 4
biome 2.4.2..2.4.15 875 /62 13 /27 12 /10 813 13

All three ranges had zero not-assessed, without-notes and unparseable versions. Fixture coverage includes pending, missing/zero/oversize statements, truncation, multi-page completeness, changed evidence, filters, sanitization and CLI/MCP parity. No backend contract problems found. Backend supersession relations for fixes later reverted remain a documented backlog item, with no client inference added.

Record the reviewed one-increment migration, authenticated schema and complexity evidence, effective filters, minimal projections and complete collection rules. Correct the backlog to distinguish resolved backend data support from remaining supersession questions.
Replace capped risk items with source-ordered statements and shared tier filters. Fetch mode-specific projections, retain whole-range triage counters and keyword evidence, and document the JSON migration with CLI/MCP parity coverage.
Close review findings across keyword text, signals and URLs; avoid repeated locators and nest sources beneath versions. Resolve view and tier selection once in the shared request builder and clarify oversize classifications in the MCP schema.
Restore aggregate security variable, minimal-selection, advisory mapping and backend error guards alongside complete statement tests. Cover strict field validation and record the final agent workload limitations.
The final Opus round is clean and all accepted findings are closed. Permanent implementation docs retain the contract, query budget, dev evidence and eval limits; the backend supersession gap remains in the backlog. Deliver for owner review without merging.
@jlitola jlitola added the enhancement New feature or request label Oct 14, 2026
@jlitola
jlitola marked this pull request as ready for review October 15, 2026 06:24
@jlitola
jlitola merged commit 7367590 into main Oct 15, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant