Warn when a literal workspace member has no manifest - #98
Merged
Merged
Conversation
A go.work use entry (or Cargo/npm/pnpm workspace member) that names a directory with no manifest was dropped silently, so callers building a release order from the discovered set got an incomplete graph with no signal. Emit a warning naming the workspace file, the member pattern as written, and the manifest it lacked. Wildcard patterns that expand to nothing stay silent. Fixes #97
A literal include also covered by an exclude pattern warned even though the workspace configuration removed it; match the literal against the exclude patterns before warning. normalizeRepositoryPath rejected /-prefixed and ../ paths but let a Windows drive-absolute entry (C:\src\svc) through, so it globbed to nothing under the reader root and produced a "has no go.mod" warning for a path outside the repository. Reject drive-letter volumes the same way as other absolute paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
go.workuseentry (or Cargo/npm/pnpm workspace member) that names a directory with no manifest was dropped silently, so callers building a release order from the discovered set got an incomplete graph with no signal.Emit a warning naming the workspace file, the member pattern as written, and the manifest it lacked. Wildcard patterns that expand to nothing stay silent since an empty match there can be intentional.
Fixes #97