entra: do not use default account on DevBox - #2459
Merged
Merged
Conversation
As of GCM 3.0, the 'UseMsAuthDefaultAccount' setting is now a tri-state flag, which has the following meanings: true => always use the OS account false => never use the OS account unset => ask to use the OS account This means that, on DevBox, where we currently special-case and return 'true' for this setting, the user has no way to sign-in to an Entra-backed provider using a _different_ account than the OS default account. Remove the special-casing of DevBox, and return `null` (unset) so the user continues to see the prompt. Until we can wire-up `continue=1` and retry logic to the Azure Repos provider, we need to make the user experience better for this scenario. Note, there is an obscure workaround: manually bind your Azure DevOps org to a different account - this is not very discoverable. Signed-off-by: Matthew John Cheetham <mjcheetham@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of GCM 3.0, the 'UseMsAuthDefaultAccount' setting is now a tri-state flag, which has the following meanings:
This means that, on DevBox, where we currently special-case and return 'true' for this setting, the user has no way to sign-in to an Entra-backed provider using a different account than the OS default account.
Remove the special-casing of DevBox, and return
null(unset) so the user continues to see the prompt.Until we can wire-up
continue=1and retry logic to the Azure Repos provider, we need to make the user experience better for this scenario.Note, there is an obscure workaround: manually bind your Azure DevOps org to a different account - this is not very discoverable.