Skip to content

dispatcher: fix macOS UI and broker auth hangs #2451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjcheetham merged 12 commits into from
Sep 23, 2026
Merged

dispatcher: fix macOS UI and broker auth hangs #2451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fe2dd3f
dispatcher: fold the untyped job into the generic one
mjcheetham Sep 17, 2026
9f71a27
dispatcher: complete jobs that throw
mjcheetham Sep 17, 2026
d180821
dispatcher: run continuations off the job thread
mjcheetham Sep 16, 2026
f5d22be
dispatcher: add overloads for asynchronous work
mjcheetham Sep 16, 2026
aee8739
dispatcher: allow shutdown before Run is reached
mjcheetham Sep 16, 2026
559e0a5
dispatcher: distinguish stopping from stopped
mjcheetham Sep 17, 2026
f5d51a6
ui: start the main loop just-in-time
mjcheetham Sep 17, 2026
b2c43a6
entra: explain the macOS broker thread requirement
mjcheetham Sep 16, 2026
c421b22
trace2: give the application thread its own context
mjcheetham Sep 17, 2026
32ba1fb
trace2: expose the thread context as a handle
mjcheetham Sep 17, 2026
d0cc0b4
dispatcher: run jobs with the caller's ambient state
mjcheetham Sep 17, 2026
e4ede93
docs: describe the main thread dispatcher
mjcheetham Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/architecture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@ GCM makes use of the `async`/`await` model of .NET and C# in almost all
parts of the codebase where appropriate as usually requests end up going to the
network at some point.

Work that must run on the process entry thread - creating UI controls, or
using the macOS identity broker - is marshalled there by the main thread
dispatcher. See the [main thread dispatcher][gcm-dispatcher] documentation for
how that works and the rules for posting to it.

## Command execution

```text
Expand Down Expand Up @@ -282,5 +287,6 @@ to the trace object in most places of GCM.
[credential-provider]: configuration.md#credentialprovider
[issue-113]: https://github.com/git-ecosystem/git-credential-manager/issues/113
[issue-136]: https://github.com/git-ecosystem/git-credential-manager/issues/136
[gcm-dispatcher]: dispatcher.md
[gcm-provider]: environment.md#GCM_PROVIDER
[msal]: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet
328 changes: 328 additions & 0 deletions docs/dispatcher.md
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading