You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The daily cargo-audit run filed 11 open issues: one rustix soundness bug, nine heapless 0.8 advisories, and chrono being unmaintained. This PR clears all of them.
rustix 1.1.4 → 1.1.6 fixes RUSTSEC-2026-0486 (UB in the xattr functions with a zero-length buffer).
heapless 0.8 (RUSTSEC-2026-0574 to 0582) enters only through faster-hex 0.10, via gix-hash and gix-packetline. faster-hex imports heapless only under cfg(not(feature = "alloc")), and both callers enable faster-hex/std, so no heapless code is compiled into our binaries. No gix release uses faster-hex 2 yet, so these get audit ignores with a removal gate: drop them when heapless 0.8 leaves Cargo.lock.
chrono (RUSTSEC-2026-0543, unmaintained, not a vulnerability) is in the lockfile only as an optional dependency of serde_with, pulled in through tauri-utils. Nothing compiles it. It gets an ignore with the same kind of gate.
The url advisory (#375) is handled in a separate PR.
Proof: local cargo audit with the new ignore list reports only the out-of-scope url advisory, where origin/main reports rustix and url. Clippy and the workspace tests pass locally. Reviewed with sol-loop: 1 round with gpt-6.2-sol. Sol verdict: approved.
Created with Claude Opus 5.5 in Claude Code (review by gpt-6.2-sol in Codex).
Summary by CodeRabbit
Chores
Updated dependency audit records for specified security advisories and documented when the related exceptions can be removed. These workflow changes do not affect app functionality.
…o advisories
rustix 1.1.6 fixes RUSTSEC-2026-0486 (xattr zero-length buffer UB).
heapless 0.8 enters only through gix-hash -> faster-hex 0.10, which uses
heapless only without its alloc feature. gix enables alloc, so no heapless
code runs, and no gix-hash release uses faster-hex 2 yet. chrono is
unmaintained, with no vulnerability, and enters only through
tauri-utils -> serde_with. Both get audit ignores with removal gates.
Closes#338, closes#345, closes#351, closes#352, closes#353,
closes#354, closes#355, closes#356, closes#357, closes#358,
closes#359
No actionable comments were generated in the recent review.
Walkthrough
The audit workflow documents ignored heapless and chrono advisories, including when to remove their exceptions. It also adds ten advisory IDs to the ignored advisory list.
Changes: Audit advisory exceptions
Layer / File(s)
Summary
Document and list advisory exceptions .github/workflows/audit.yml
Comments describe the stated sources and compile status for heapless and chrono advisories, and specify when to remove their exceptions. The audit ignore list adds RUSTSEC-2026-0574 through RUSTSEC-2026-0582 and RUSTSEC-2026-0543.
This change updates the audit workflow to ignore several advisories and documents when to remove each exception. It does not alter runtime behavior. No actionable merge-blocking risk remains.
Provide the Cargo.lock diff for the rustix package. It must show 1.1.4 changed to 1.1.6, or the lock entry that proves the bump. Provide the output of cargo tree -i heapless --target all -e features and `cargo tree -i chrono --target all …
Passed checks: 3 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title names two of the PR's changes: the rustix advisory fix and the heapless/chrono audit ignores. It is specific and scannable. The PR also updates rustix from 1.1.4 to 1.1.6, which matches the …
Out of Scope Changes check
The reviewed changes in .github/workflows/audit.yml update only audit ignore entries and their comments. The ignored entries match the advisories in #338, #345, and #351-#359. The raw summary reports …
Full details: Title check
Explanation
The title names two of the PR's changes: the rustix advisory fix and the heapless/chrono audit ignores. It is specific and scannable. The PR also updates rustix from 1.1.4 to 1.1.6, which matches the title. The title does not mention the new RUSTSEC-2026-0574 to 0582 ignore range or the removal gates, but it covers the main change without being misleading. The title uses the conventional ci(deps) prefix, which fits a workflow and lockfile change.
Full details: Out of Scope Changes check
Explanation
The reviewed changes in .github/workflows/audit.yml update only audit ignore entries and their comments. The ignored entries match the advisories in #338, #345, and #351-#359. The raw summary reports no public API or code changes. The PR description ties the rustix bump to #338. The Cargo.lock change is excluded from review, so its content is not checked. The described rustix update maps directly to #338 and no unrelated change is described. The URL advisory (#375) is stated as out of scope and handled in another PR.
Evidence reviewed: .github/workflows/audit.yml adds ignores for RUSTSEC-2026-0574 through RUSTSEC-2026-0582 and RUSTSEC-2026-0543, with removal gates tied to heapless 0.8 and chrono leaving Cargo.lock. The PR description states that rustix moves from 1.1.4 to 1.1.6.
Unverified: Cargo.lock is excluded by the ignored_files rule '!**/*.lock', so the rustix version bump cannot be inspected. This leaves #338 unconfirmed. The claims that heapless and chrono are not compiled rely on the dependency graph in Cargo.lock and on the author's analysis of faster-hex, gix-hash, gix-packetline, serde_with, and tauri-utils. These claims also cannot be checked from the reviewed evidence.
Assessment of the approach: the heapless and chrono items are resolved by audit ignores, not by code or dependency changes. Whether an ignore satisfies issues that request remediation is a scope decision. The issue text for #345 recommends alternatives, and the PR does not adopt one.
Resolution
Provide the Cargo.lock diff for the rustix package. It must show 1.1.4 changed to 1.1.6, or the lock entry that proves the bump. Provide the output of cargo tree -i heapless --target all -e features and cargo tree -i chrono --target all -e features at the reviewed head. These outputs must show that no compiled path reaches heapless or chrono. Confirm that the maintainers accept audit ignores as the resolution for #345 and #351-#359.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Fix failing CI checks
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
File: No configuration file from this repository applied
Commit: Unavailable
Layers: defaults
Review profile: CHILL
Plan: Advanced
Run ID: a78e9c1b-b05b-4b07-968e-c2a49179e442
Commits
Reviewing files that changed from the base of the PR and between 25768ac and 2b7a24f.
Files ignored due to path filters: 1
Cargo.lock is excluded by !**/*.lock
Files selected for processing: 1
.github/workflows/audit.yml
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily cargo-audit run filed 11 open issues: one rustix soundness bug, nine heapless 0.8 advisories, and chrono being unmaintained. This PR clears all of them.
cfg(not(feature = "alloc")), and both callers enablefaster-hex/std, so no heapless code is compiled into our binaries. No gix release uses faster-hex 2 yet, so these get audit ignores with a removal gate: drop them when heapless 0.8 leavesCargo.lock.The url advisory (#375) is handled in a separate PR.
Closes #338, closes #345, closes #351, closes #352, closes #353, closes #354, closes #355, closes #356, closes #357, closes #358, closes #359
Proof: local
cargo auditwith the new ignore list reports only the out-of-scope url advisory, whereorigin/mainreports rustix and url. Clippy and the workspace tests pass locally. Reviewed with sol-loop: 1 round with gpt-6.2-sol. Sol verdict: approved.Created with Claude Opus 5.5 in Claude Code (review by gpt-6.2-sol in Codex).
Summary by CodeRabbit