Skip to content

fix(deps): bump url to 2.5.9 to clear RUSTSEC-2026-0592 - #378

Open
tonibergholm wants to merge 1 commit into
mainfrom
bump-url-2.5.9
Open

tonibergholm wants to merge 1 commit into
mainfrom
bump-url-2.5.9

Conversation

@tonibergholm

Copy link
Copy Markdown
Member

cargo audit has been red on main since RUSTSEC-2026-0592 was published: url 2.5.8 recurses without bound in Url::origin() on nested blob: URLs, which aborts the process. Nothing here calls Url::origin() on untrusted input as far as I can tell, but the failing audit hides real new advisories.

Bumps url to 2.5.9, the patched release. It is a transitive dependency, so this is a Cargo.lock-only change (form_urlencoded 1.2.2 to 1.2.3 comes along).

Closes #375.

Proved with: cargo fmt --all --check and cargo clippy --workspace --all-targets -- -D warnings pass locally; the full local test run timed out, so cargo test and cargo audit are proven by CI on this PR.

Created with Claude Sonnet 5.5 in Claude Code.

url <= 2.5.8 recurses without bound in Url::origin() on nested blob: URLs.
Lockfile-only bump (url is transitive); form_urlencoded 1.2.3 comes along.

Created with Claude Sonnet 5.5 in Claude Code.
@coderabbitai

coderabbitai Bot commented Nov 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1

  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 47ed99a0-bf32-4ed0-8d0d-432996deeacd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 22, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-22T18:33:39.127073Z ba1d954 PR opened
🔒 Security Review ✅ Completed 2026-11-22T18:35:59.261333Z ba1d954 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2026-0592: Stack overflow in Url::origin() on nested blob: URLs

1 participant