Repository navigation
docs: sc+git:: works on GitHub (validated), slow but correct - #372
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm
approved these changes
Nov 21, 2026
tonibergholm
left a comment
Member
There was a problem hiding this comment.
Approved: docs-only record of the GitHub validation run; CI green on 5a69996.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sc+git::docs said "not tested against GitHub", and GitHub was the host Theo's thread was about. I ran the full scenario against a private GitHub repository and recorded what happened.What the run showed (git 2.54, HTTPS through the gh credential helper, synthetic keys and content only):
refs/sc/*. A plaingit clonefetched none of them.hotfix (private, no access), with no protected plaintext and no secret value. A keyed clone decrypted the protected file, injected the secret and read the private branch.non-fast-forward.ref-prefix refs/sc/manifest, and GitHub answered with that ref only.sc-git-bucket-*cache was left behind.Not exercised on GitHub, and still listed as open: its per-push (2 GiB) and per-blob (100 MB) limits, rulesets on custom refs, and CAS atomicity across its replicas beyond one race. The scratch repository's refs were all deleted after the run.
Proof: the run's output in this session. The only failure was a check in my script that read a protected file before switching with the key. Rerun with the key, it decrypted.
Docs only: ADR-0060, ADR-0057, THREAT-MODEL, ROADMAP, CLAUDE.md, README and the CLI skill.
Created with Claude Opus 5.5 in Claude Code (T3 Code).