Skip to content

Reconcile the threat model with the November security fixes - #153

Merged
tonibergholm-codento merged 4 commits into
mainfrom
reconcile-threat-model
Nov 20, 2026
Merged

tonibergholm-codento merged 4 commits into
mainfrom
reconcile-threat-model

Conversation

@tonibergholm-codento

Copy link
Copy Markdown
Collaborator

The threat model still described the pre-November state. Several rows called controls closed that were only partly in place, two rows from July had never been reconciled, and the fixes merged today (#145 to #152) had no rows at all.

This updates the table rows, the focus-path table and the closing notes, and adds a 2026-11-20 revision entry. The narrative sections stay as the original 2026-05-21 analysis.

Proof: every changed claim was checked against source on main. Three Sol review rounds removed nine overclaims, and the last two findings are applied here.

Reviewed with sol-loop: 3 rounds with gpt-6.2-sol; the final round's two findings are fixed in the last commit.

Created with Claude Opus 5.5 and Claude Sonnet 5.5 in Claude Code.

Re-open the TM-001 and TM-002 residual (per-operation authorization, plain rollback without a token), reconcile TM-004, TM-005, TM-007, TM-008, TM-009 and TM-010, and add TM-011 to TM-013.
Rows that depend on PRs #151 and #152 say they are not yet merged.
Narrative sections are unchanged.
Scope the TM-007 text to what the daemon does: it only consumes a supplied bearer token, ADR-0015 is Proposed and stays inside the shared identity, and PR #152 is an opt-in file path plus Debug redaction.
Limit the TM-010 redaction claim to URL userinfo and keep the row open.
State the ReadObject payload cap and typed-getter scope in TM-001, and the single-use scope in TM-002.
Separate the global commit queue, per-UID rate and accept-time connection caps in TM-004.
Narrow the TM-008 preflight claims, the TM-011 verification and ordering claims, the TM-005 priority, and the TM-013 strict-mode behavior.
Mark TM-011 mitigated by PR #151 and say plainly that the store verifies the address while the typed loaders enforce the expected kind.
Describe PR #152 as merged, and scope its Debug redaction to GcsObjectStore and MemoryBackendSpec. The env and argv claim applies only to credentials supplied through the new file options. GcsObjectStore Debug did not redact the token before #152.
Restore the TM-013 mitigation, detection and likelihood cells and drop the claim that unknown types are refused.
Update the Revisions header and closing notes.
@coderabbitai

coderabbitai Bot commented Nov 20, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 74bb4b83-3685-448a-9702-1d762bc59d9f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T08:21:59.775246Z 387ccc1 PR opened
🔒 Security Review ✅ Completed 2026-11-20T08:23:23.778510Z 387ccc1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tonibergholm-codento
tonibergholm-codento merged commit 32a13c1 into main Nov 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant