Repository navigation
Reconcile the threat model with the November security fixes - #153
Merged
Merged
Conversation
Scope the TM-007 text to what the daemon does: it only consumes a supplied bearer token, ADR-0015 is Proposed and stays inside the shared identity, and PR #152 is an opt-in file path plus Debug redaction. Limit the TM-010 redaction claim to URL userinfo and keep the row open. State the ReadObject payload cap and typed-getter scope in TM-001, and the single-use scope in TM-002. Separate the global commit queue, per-UID rate and accept-time connection caps in TM-004. Narrow the TM-008 preflight claims, the TM-011 verification and ordering claims, the TM-005 priority, and the TM-013 strict-mode behavior.
Mark TM-011 mitigated by PR #151 and say plainly that the store verifies the address while the typed loaders enforce the expected kind. Describe PR #152 as merged, and scope its Debug redaction to GcsObjectStore and MemoryBackendSpec. The env and argv claim applies only to credentials supplied through the new file options. GcsObjectStore Debug did not redact the token before #152. Restore the TM-013 mitigation, detection and likelihood cells and drop the claim that unknown types are refused. Update the Revisions header and closing notes.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The threat model still described the pre-November state. Several rows called controls closed that were only partly in place, two rows from July had never been reconciled, and the fixes merged today (#145 to #152) had no rows at all.
This updates the table rows, the focus-path table and the closing notes, and adds a 2026-11-20 revision entry. The narrative sections stay as the original 2026-05-21 analysis.
accept_data_loss=false) runs unmarked reverse migrations and restores memory without a token. Per-operation authorization needs an owner decision.PgConfigredacts only URL userinfo.Proof: every changed claim was checked against source on main. Three Sol review rounds removed nine overclaims, and the last two findings are applied here.
Reviewed with sol-loop: 3 rounds with gpt-6.2-sol; the final round's two findings are fixed in the last commit.
Created with Claude Opus 5.5 and Claude Sonnet 5.5 in Claude Code.