Skip to content

Pin CI actions and sidecar base images to immutable references - #148

Merged
tonibergholm-codento merged 2 commits into
mainfrom
pin-ci-actions
Nov 20, 2026
Merged

tonibergholm-codento merged 2 commits into
mainfrom
pin-ci-actions

Conversation

@tonibergholm-codento

Copy link
Copy Markdown
Collaborator

Workflows referenced third-party actions by floating tags and branches, including the PyPI publish action in the job that holds id-token: write. A moved tag upstream would run new code in that job. The sidecar image also built from tag-only base images without --locked.

Every uses: now names a full commit SHA, with the tag in a trailing comment. Each pin is the latest release in the major version the workflow already used. Dockerfile.sidecar pins both base images by digest and builds with cargo build --locked. Workflow behavior is unchanged: the diff touches only uses: lines.

Proof: actionlint passes, and a grep finds no unpinned uses:. Sol checked each SHA against its upstream tag or branch. docker build -f crates/agenticd/Dockerfile.sidecar . succeeded locally. This PR's own CI run is the first hosted run of the pinned actions.

Reviewed with sol-loop: 2 rounds with gpt-6.2-sol. Sol verdict: approved

Created with Claude Opus 5.5 and Claude Sonnet 5.5 in Claude Code.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 81918d10-35b8-4ea7-a342-38708c8103d5
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T07:35:57.712365Z 4a984ca New commits
🔒 Security Review ✅ Completed 2026-11-20T07:38:15.874127Z 4a984ca New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Pin every third-party action in .github/workflows to a full commit SHA
with a trailing tag comment, so a moved tag or branch cannot change what
CI executes. dtolnay/rust-toolchain reads the toolchain from its ref
name, so each use now passes toolchain: 1.95.0 explicitly.

In Dockerfile.sidecar, pin both base images by multi-arch index digest
and build agenticd with --locked so Cargo.lock is enforced.
The pinned commit of the 1.95.0 branch hardcodes the toolchain and
declares no toolchain input, so the extra input only produced warnings.
@tonibergholm-codento
tonibergholm-codento merged commit aaf133a into main Nov 20, 2026
16 checks passed

This branch was successfully deployed

1 active deployment
website-preview — 4a984cab Deployed Nov 20, 2026 by tonibergholm-codento via deploy #17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant