Repository navigation
Bind demo and test services to localhost - #146
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
tonibergholm-codento
deployed
to
website-preview
November 20, 2026 07:15 — with
GitHub Actions
Active
…ls from cert script The demo Postgres (credentials agentic:agentic), the test Postgres and fake-gcs published their ports on all interfaces. Publish them on 127.0.0.1 only; every consumer already connects via localhost. website/deploy/finish-certs.sh hard-coded the contact email and the name of a personal server. The email now comes from the required CERT_EMAIL variable, which fails fast when unset, and the hostname is removed from the header comment.
tonibergholm-codento
force-pushed
the
demo-localhost-binds
branch
from
November 20, 2026 07:20
f51a837 to
eac89c2
Compare
tonibergholm-codento
deployed
to
website-preview
November 20, 2026 07:20 — with
GitHub Actions
Active
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo and test compose files published Postgres (with the
agentic:agenticlogin) and fake-gcs on every network interface, so anyone on the same network could connect while the demo ran. The cert script also hard-coded a contact email.Every published port now binds to 127.0.0.1. All consumers already connect through localhost.
website/deploy/finish-certs.shreads the certbot address from a requiredCERT_EMAILvariable and stops with a clear message when it is unset.Proof:
docker compose configshowshost_ip: 127.0.0.1for all three files. The demo Postgres answers on 127.0.0.1 and not on the machine's LAN address. The script exits 1 before doing anything whenCERT_EMAILis unset.Reviewed with sol-loop: 1 round with gpt-6.2-sol. Sol verdict: approved
Created with Claude Opus 5.5 and Claude Sonnet 5.5 in Claude Code.