Skip to content

Create a new BE from the selected boot environment - #22

Merged
ericbsd merged 2 commits into
masterfrom
ghostbsd/issues#218
Sep 16, 2026
Merged

ericbsd merged 2 commits into
masterfrom
ghostbsd/issues#218

Conversation

@ericbsd

@ericbsd ericbsd commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

The create dialog now uses the boot environment selected in the list as the source for the new BE, and shows that source in the dialog so the user knows which BE is being copied. This maps to bectl create -e.

Dialog variables in the create, rename and delete handlers were also given distinct names instead of sharing a generic dialog.

Resolves ghostbsd/issues#218

Summary by Sourcery

Create boot environments from the selected source and clarify dialog state management.

New Features:

  • Create new boot environments from the boot environment selected in the list and display the selected source in the create dialog.

Enhancements:

  • Use distinct dialog variables across create, rename, and delete handlers.

The create dialog now uses the boot environment selected in the list as
the source for the new BE, and shows that source in the dialog so the
user knows which BE is being copied. This maps to `bectl create -e`.

Dialog variables in the create, rename and delete handlers were also
given distinct names instead of sharing a generic `dialog`.

Resolves ghostbsd/issues#218
@ericbsd
ericbsd requested review from a team as code owners September 15, 2026 20:52
@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

The create workflow now copies from the boot environment selected in the list and visibly identifies that source in the dialog, while handler-local dialog variables were renamed to avoid ambiguity across create, rename, and delete operations.

File-Level Changes

Change Details Files
Use the boot environment selected in the list as the source when creating a new boot environment.
  • Pass the selected boot environment to the create operation, matching bectl create -e.
  • Display the selected source boot environment in the create dialog for confirmation.
backup-station
Disambiguate dialog state across boot environment actions.
  • Rename dialog variables in the create, rename, and delete handlers to use distinct names.
backup-station

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@ericbsd
ericbsd merged commit 8f9f263 into master Sep 16, 2026
1 check passed
@ericbsd
ericbsd deleted the ghostbsd/issues#218 branch September 16, 2026 11:15
@github-project-automation github-project-automation Bot moved this from In Review to Done in Development Tracker Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Backup Station should create a BE from the selected BE instead of the booted one.

2 participants