Repository navigation
model : MTP support for Mellum2.1 - #30612
Merged
Merged
Conversation
CISC
approved these changes
Oct 15, 2026
edwardyoon
pushed a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 24, 2026
* model : MTP support for Mellum * model : inline rope construction in Mellum
edwardyoon
added a commit
to edwardyoon/focus-llama
that referenced
this pull request
Oct 25, 2026
mellum.cpp (upstream ggml-org#30612, applied cleanly during the 399-commit fast-forward) references three infra helpers that were dropped by the 124 conflicted commits. They are added here without cherry-picking the full upstream commits, which would not compile locally: - crop_before_nextn() / crop_after_nextn() on llm_graph_context (ggml-org#30017) - nextn_flags_t / nextn_flags() on llama_model_base (ggml-org#30097) - 2-arg llm_graph_input_embd_h ctor (n_embd, n_embd_state) (ggml-org#30257) The ctor is an overload, not a replacement: the 10 models that call the 1-arg form keep working because n_embd_state defaults to n_embd, so set_input() byte-for-byte matches their prior behavior. set_input() now sizes the hidden-state tensor from n_embd_state (mellum's n_embd_inp() differs from n_embd). Verified: cmake --build --target llama passes (error 0).
auRose94
pushed a commit
to auRose94/llama.cpp
that referenced
this pull request
Oct 28, 2026
* model : MTP support for Mellum * model : inline rope construction in Mellum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Continuation of #30578
Should be merged after #30584 (on the Metal backend the MTP graph yields NaN without a fix)
graph_mtpforllama_model_mellum--no-mtp,--mtpand default (combined) GGUFsAdditional information
https://huggingface.co/collections/JetBrains/mellum21 (the model with MTP will be available soon)
Perplexity
llama-perplexity -f wiki.test.raw -c 512 -ngl 99, 591 chunks, all per-chunk values identical:Benchmarks
setup: Apple M2 Max, Metal, full GPU offload
llama-server -ngl 99 -c 8192 -np 1 -fa on --jinja [--spec-type draft-mtp --spec-draft-n-max N], 512 generated tokens, temperature 0, mean of 2 runsModel: combined BF16
Model: trunk-only BF16 + MTP-only BF16
Model: trunk-only Q4_K_M + MTP-only Q8_0
Requirements