Repository navigation
fix(service): Count only filtered skill findings in outcome totals - #572
Merged
Merged
Conversation
The dashboard summary and outcome summary summed runs.finding_count for any run that included the filtered skill, so a skill filter reported findings from every other skill in those runs. Sum the matching skill executions' finding counts instead, so totals agree with the findings list. Co-Authored-By: Jeffrey Hung <jeffrey.hung@sentry.io>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Jeffreyhung
approved these changes
Nov 11, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you filter the Usage dashboard by skill, it reports findings from every skill in the matching runs. With
skill=integrity-reviewover 7 days, Usage showed 23 findings while the Findings view showed 2.aggregateOutcomeRow, which backs/api/v1/dashboard/summaryand/api/v1/outcomes/summary, summedruns.finding_count. That column is the total for the whole run. The skill filter only decided which runs to include, so it didn't narrow what got counted. Now, when askillorerrorCodefilter is set, each run adds upskill_executions.finding_countfrom just the matching executions. That matches whatlistFindingscounts. Unfiltered totals don't change.Run counts (
runs,successful,failed, and so on) still count whole runs that included the skill, not individual skill executions. I left them alone because changing them changes what those numbers mean. That's a separate call if you want it.The new integration assertion ingests one run with two skills and checks the per-skill totals. I ran it against a local PGlite Postgres server: it fails without this change (reports 3 findings for a skill that has 2) and passes with it. On this setup, the "Finding URL migration" and "Postgres query plans" integration tests fail on
maintoo, so those failures aren't from this change.via Jeffrey Hung.
--
View Session [Sentry]