Repository navigation
fix(search-issues): Report counts that match the query's event filters - #2140
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
search_issues reported each issue's top-level count as occurrences. Sentry computes that count over the time range and the environment URL parameter only, so event filters in the query string, such as environment:production, are not applied. The issues endpoint returns those filtered counts in filtered.count and filtered.userCount (StreamGroupSerializerSnuba in getsentry/sentry). Prefer the filtered counts when Sentry returns them, so occurrences and usersImpacted match the query the caller ran. Co-Authored-By: Sergiy Dybskiy <3760543+sergical@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
search_issuesuses each issue's top-levelcount/userCountforoccurrences/usersImpacted(results.ts:148on main). Sentry computes those top-level counts from the time range and theenvironmentURL parameter only. Event filters in the query string, such asenvironment:production, are not applied. The issues endpoint returns the counts that do apply them infiltered.count/filtered.userCount. That field is documented as "events that match the search query" and is null when the query has no such filters.Sentry source (getsentry/sentry
src/sentry/api/serializers/models/group_stream.py):__seen_stats_impl(L871) runs the time-range query withenvironment_idsonly, and runs it again withconditions=self.conditions(L891) to fillfiltered(L776-789).User feedback reported
search_issuesoccurrences that didn't match an environment-filteredsearch_errorsaggregate for the same issue and window. Traces showed the serializer running both seen-stats queries, one without the environment condition and one with it, and MCP reporting the unfiltered one.Change
IssueSchemagains an optional, nullablefiltered: {count, userCount}.buildIssueResultsprefersfilteredcounts when Sentry returns them, and otherwise falls back to the top-level counts.listIssuesonly collapsesunhandled, sofilteredis already in the response. The CLI made the same change forrelease:queries in #1590.via @sergical.
--
View Session [Sentry]