Repository navigation
fix(mcp): Warn instead of reporting issues on stacktrace-link 5xx - #2131
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
get_issue_details, resolving the code location via Sentry's/projects/{org}/{project}/stacktrace-link/endpoint is an optional enrichment. When Sentry returns an HTTP 5xx (e.g. on Python projects),resolveCodeLocationthrew anApiServerErrorthat slipped through the catch block's suppression checks (which only excludedApiClientErrorandConfigurationError) and got sent to Sentry vialogIssue.This change downgrades upstream
ApiServerErrorfailures inresolveCodeLocationtologWarnwith the status, organization, project, and group ID attached, while continuing to returnundefinedso thatget_issue_detailssucceeds without the optional Code Location section. Unexpected non-API errors (e.g. bugs or parsing errors) continue to be reported vialogIssue.Fixes MCP-SERVER-G3V
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.