Skip to content

ref(lint): Enable no-unnecessary-type-arguments #2128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JoshuaKGoldberg wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

ref(lint): Enable no-unnecessary-type-arguments #2128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"allow": ["URL", "URLSearchParams"]
}
],
"typescript/no-unnecessary-type-arguments": "error",
"jsx-a11y/interactive-supports-focus": "off",
"unicorn/prefer-spread": "error"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/test/lib/mcp/parse-flags.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export async function parseMcpFlags(
export async function parseMcpArgs(args: readonly string[]): Promise<McpArgs> {
let parsed: McpArgs | undefined;
let stderr = "";
const command = buildCommand<McpFlags, McpPositional, CommandContext>({
const command = buildCommand<McpFlags, McpPositional>({
docs: { brief: "Parse sentry mcp flags" },
parameters: (mcpCommand as unknown as { parameters: McpParameters })
.parameters,
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-core/src/internal/agents/callEmbeddedAgent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ interface EmbeddedAgentResult<T> {
*/
export async function callEmbeddedAgent<
TOutput,
TSchema extends z.ZodType<TOutput, unknown>,
TSchema extends z.ZodType<TOutput>,
>({
system,
prompt,
Expand Down Expand Up @@ -395,7 +395,7 @@ function extractJsonCandidates(text: string): string[] {
*/
function rescueFromText<TOutput>(
text: string,
schema: z.ZodType<TOutput, unknown>,
schema: z.ZodType<TOutput>,
): TOutput | null {
for (const candidate of extractJsonCandidates(text)) {
try {
Expand Down
Loading