ref(lint): Enable no-unnecessary-boolean-literal-compare

.oxlintrc.json

@@ -37,6 +37,7 @@
         "allow": ["URL", "URLSearchParams"]
       }
     ],
+    "typescript/no-unnecessary-boolean-literal-compare": "error",
     "jsx-a11y/interactive-supports-focus": "off",
     "unicorn/prefer-spread": "error"
   },

packages/cli/src/commands/alert/issues/edit.ts

@@ -334,7 +334,7 @@ export const editCommand = buildCommand({
       id: stringifyUnknown(updated.id ?? rule.id),
       // The workflows endpoint returns `enabled` rather than `status`; map it
       // back to a status label so human/JSON output matches the create path.
-      status: updated.enabled === false ? "disabled" : "active",
+      status: !updated.enabled ? "disabled" : "active",
     } satisfies IssueAlertEditOutput);
   },
 });

packages/cli/src/commands/alert/metrics/edit.ts

@@ -326,7 +326,7 @@ export const editCommand = buildCommand({
       org: orgSlug,
       id: stringifyUnknown(updated.id ?? rule.id),
       // The detectors endpoint returns `enabled` rather than `status`.
-      status: updated.enabled === false ? "disabled" : "active",
+      status: !updated.enabled ? "disabled" : "active",
     } satisfies MetricAlertEditOutput);
   },
 });

packages/cli/test/skill-eval/helpers/judge.ts

@@ -137,7 +137,7 @@ or
     }
 
     const parsed = JSON.parse(jsonMatch[0]) as {
-      pass: boolean;
+      pass: unknown;
       reason: string;
     };
     return {

packages/mcp-core/src/tools/tools.test.ts

@@ -82,10 +82,7 @@ test("unlisted tools declare a unique display title", () => {
 test("no tool is both read-only and destructive", () => {
   for (const tool of Object.values(tools.default)) {
     assert(
-      !(
-        tool.annotations.readOnlyHint === true &&
-        tool.annotations.destructiveHint === true
-      ),
+      !(tool.annotations.readOnlyHint && tool.annotations.destructiveHint),
       `${tool.name} cannot be both read-only and destructive`,
     );
   }