ref(lint): Enable no-unnecessary-template-expression

.oxlintrc.json

@@ -37,6 +37,7 @@
         "allow": ["URL", "URLSearchParams"]
       }
     ],
+    "typescript/no-unnecessary-template-expression": "error",
     "jsx-a11y/interactive-supports-focus": "off",
     "unicorn/prefer-spread": "error"
   },

packages/cli/src/commands/issue/resolve-commit-spec.ts

@@ -161,7 +161,7 @@ export async function resolveCommitSpec(
   if (!match) {
     throw new ValidationError(
       `--in @commit:${spec.repository}@${spec.commit}: no Sentry repository named '${spec.repository}' in organization '${orgSlug}'.\n\n` +
-        `${formatAvailableRepos(sentryRepos)}`,
+        formatAvailableRepos(sentryRepos),
       "in",
     );
   }

packages/cli/src/lib/db/pagination.ts

@@ -518,7 +518,7 @@ export function buildMultiTargetContextKey(
     ? escapeContextKeyValue(filters.query)
     : undefined;
   return (
-    `${base}` +
+    base +
     (escapedSort ? `|sort:${escapedSort}` : "") +
     `|period:${escapedPeriod}` +
     (escapedQuery ? `|q:${escapedQuery}` : "") +

packages/cli/src/lib/formatters/human.ts

@@ -2423,9 +2423,7 @@ export function formatUpgradeResult(data: UpgradeResult): string {
     default: {
       // Exhaustive check — all action types should be handled above
       const _: never = data.action;
-      lines.push(
-        `${ACTION_DESCRIPTIONS[_ as UpgradeResult["action"]] ?? "Done"}`,
-      );
+      lines.push(ACTION_DESCRIPTIONS[_ as UpgradeResult["action"]] ?? "Done");
     }
   }
 

packages/cli/test/lib/command.test.ts

@@ -1213,7 +1213,7 @@ describe("buildCommand return-based output", () => {
       auth: false,
       docs: { brief: "Test" },
       output: {
-        human: (d: { id: number; name: string; role: string }) => `${d.name}`,
+        human: (d: { id: number; name: string; role: string }) => d.name,
       },
       parameters: {},
       async *func(this: TestContext) {

packages/cli/test/lib/delta-upgrade.mocked.test.ts

@@ -227,7 +227,7 @@ describe("resolveNightlyDelta", () => {
                 mediaType: "application/octet-stream",
                 size: 1000,
                 annotations: {
-                  "org.opencontainers.image.title": `${BINARY_NAME}`,
+                  "org.opencontainers.image.title": BINARY_NAME,
                 },
               },
             ],

packages/cli/test/lib/formatters/output.test.ts

@@ -66,7 +66,7 @@ describe("renderCommandOutput", () => {
   test("renders JSON when json=true", () => {
     const w = createTestWriter();
     const config: OutputConfig<{ id: number; name: string }> = {
-      human: (d) => `${d.name}`,
+      human: (d) => d.name,
     };
     render(w, { id: 1, name: "Alice" }, config, { json: true });
     expect(JSON.parse(w.output)).toEqual({ id: 1, name: "Alice" });

packages/cli/test/lib/formatters/text-table.test.ts

@@ -376,7 +376,9 @@ describe("truncate option", () => {
   });
 
   test("ellipsis inherits ANSI color from surrounding text", () => {
-    const colored = `${chalk.hex("#898294")("A very long colored text that will be truncated at the boundary")}`;
+    const colored = chalk.hex("#898294")(
+      "A very long colored text that will be truncated at the boundary",
+    );
     const out = renderTextTable(["VAL"], [[colored]], {
       maxWidth: 30,
       truncate: true,

packages/cli/test/lib/hex-id.test.ts

@@ -202,7 +202,7 @@ describe("validateHexId", () => {
   });
 
   test("throws for newline-separated IDs (not a single valid ID)", () => {
-    const multiLine = `${VALID_ID}\n${"bbbb1111cccc2222dddd3333eeee4444"}`;
+    const multiLine = `${VALID_ID}\nbbbb1111cccc2222dddd3333eeee4444`;
     expect(() => validateHexId(multiLine, "test ID")).toThrow(ValidationError);
   });
 

packages/mcp-cloudflare/src/client/components/fragments/stdio-setup.tsx

@@ -14,7 +14,7 @@ export default function StdioSetup() {
   const mcpStdioSnippet = `npx ${NPM_PACKAGE_NAME}@latest`;
 
   const selfHostedHostExample = [
-    `${mcpStdioSnippet}`,
+    mcpStdioSnippet,
     "--access-token=sentry-user-token",
     "--host=sentry.example.com",
   ].join(" \\\n  ");
@@ -63,10 +63,9 @@ export default function StdioSetup() {
         </ul>
         <p>Now wire up that token to the MCP configuration:</p>
         <CodeSnippet
-          snippet={[
-            `${mcpStdioSnippet}`,
-            "--access-token=sentry-user-token",
-          ].join(" \\\n  ")}
+          snippet={[mcpStdioSnippet, "--access-token=sentry-user-token"].join(
+            " \\\n  ",
+          )}
         />
         <div className="mt-6">
           <h4 className="text-base font-semibold text-slate-100">

packages/mcp-core/src/internal/formatting.ts

@@ -1464,7 +1464,7 @@ function formatN1QueryEvidence(
   // Format parent span info if available
   if (evidenceData.parentSpan) {
     parts.push("**Parent Operation:**");
-    parts.push(`${evidenceData.parentSpan}`);
+    parts.push(evidenceData.parentSpan);
     parts.push("");
   }
 
@@ -1562,7 +1562,7 @@ function formatSlowDbQueryEvidence(
   // Show parent span if available (generic field that applies to slow queries)
   if (evidenceData.parentSpan) {
     parts.push("**Parent Operation:**");
-    parts.push(`${evidenceData.parentSpan}`);
+    parts.push(evidenceData.parentSpan);
     parts.push("");
   }
 
@@ -2073,7 +2073,7 @@ function formatGenericEventOutput(event: Event): string {
     for (const display of occurrence.evidenceDisplay) {
       if (display.important) {
         parts.push(`**${display.name}:**`);
-        parts.push(`${display.value}`);
+        parts.push(display.value);
         parts.push("");
       }
     }