Skip to content

fix: race condition in threading mocks #8228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fricklerhandwerk wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

fix: race condition in threading mocks #8228

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a20ce4
test(utils): Share the thread patching setup between threading tests
fricklerhandwerk Nov 9, 2026
fbcdcbd
test(utils): Expose that thread mocks break on other callers
fricklerhandwerk Nov 9, 2026
69b2fa7
test(utils): Make threading mocks answer only the thread under test
fricklerhandwerk Nov 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 33 additions & 26 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1180,50 +1180,57 @@ def target():
assert (thread.ident, thread.name) == results.get(timeout=1)


def test_get_current_thread_meta_bad_running_thread():
def get_current_thread_meta_patched(fake_thread):
results = Queue(maxsize=1)
patched = threading.Event()
other_caller_done = threading.Event()
real_current_thread = threading.current_thread

def current_thread():
if threading.get_ident() == thread.ident:
return fake_thread
return real_current_thread()

def target():
with mock.patch("threading.current_thread", side_effect=["fake thread"]):
with mock.patch("threading.current_thread", current_thread):
patched.set()
other_caller_done.wait()
results.put(get_current_thread_meta())

thread = threading.Thread(target=target)
thread.start()
patched.wait()
try:
thread.join(0)
finally:
other_caller_done.set()
thread.join()
return results.get(timeout=1)


def test_get_current_thread_meta_bad_running_thread():
main_thread = threading.main_thread()
assert (main_thread.ident, main_thread.name) == results.get(timeout=1)
assert (
main_thread.ident,
main_thread.name,
) == get_current_thread_meta_patched("fake thread")


def test_get_current_thread_meta_main_thread():
results = Queue(maxsize=1)

def target():
# mock that somehow the current thread doesn't exist
with mock.patch("threading.current_thread", side_effect=[None]):
results.put(get_current_thread_meta())

main_thread = threading.main_thread()

thread = threading.Thread(target=target)
thread.start()
thread.join()
assert (main_thread.ident, main_thread.name) == results.get(timeout=1)
# mock that somehow the current thread doesn't exist
assert (
main_thread.ident,
main_thread.name,
) == get_current_thread_meta_patched(None)


def test_get_current_thread_meta_failed_to_get_main_thread():
results = Queue(maxsize=1)

def target():
with mock.patch("threading.current_thread", return_value="fake thread"):
results.put(get_current_thread_meta())

main_thread = threading.main_thread()

thread = threading.Thread(target=target)
thread.start()
thread.join()
assert (main_thread.ident, main_thread.name) == results.get(timeout=1)
assert (
main_thread.ident,
main_thread.name,
) == get_current_thread_meta_patched("fake thread")


@pytest.mark.parametrize(
Expand Down