Skip to content

feat(bedrock): Add extension skeleton - #8226

Merged
alexander-alderman-webb merged 2 commits into
masterfrom
webb/bedrock/skeleton
Nov 9, 2026
Merged

alexander-alderman-webb merged 2 commits into
masterfrom
webb/bedrock/skeleton

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Nov 9, 2026 •

Copy link
Copy Markdown
Collaborator

Add a basic bedrock extension that creates chat spans with the gen_ai.operation.name, gen_ai.provider.name and gen_ai.response.streaming attributes.

This is the first boto3 extension. I've cleaned up some things:

  • Remove registry.py. We control all extensions in the SDK, so this indirection seems unnecessary.
  • Related to the above, remove tests for the registry system that define mock extensions. Create success and error test cases in test_bedrock.py so the relevant behavior is still exercised.
  • Remove capture_internal_exceptions() around invocations of extension functions. If there's code that can raise in the extensions, the extensions can wrap the relevant lines themselves.
  • Add a skip_if_no_active_span boolean so that Bedrock spans are created even when there is no active span, matching the behavior of other chat integrations.

@alexander-alderman-webb
alexander-alderman-webb force-pushed the webb/bedrock/skeleton branch 4 times, most recently from 819486b to 3fc87ab Compare November 9, 2026 09:37
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 9, 2026 09:41
@alexander-alderman-webb
alexander-alderman-webb requested a review from a team as a code owner November 9, 2026 09:41

@cursor cursor Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@github-actions

github-actions Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 137283 passed | ⏭️ 7575 skipped | Total: 144858 | Pass Rate: 94.77% | Execution Time: 447m 51s

All tests are passing successfully.

✅ Patch coverage is 91.18% (31 of 34 changed executable lines covered; target 80%).
Project statement coverage is 90.29% (down 0.06 percentage points from base (d565fed) to head (f532a4f)).

Changed files with executable lines (4)
File Patch coverage Changed executable lines
sentry_sdk/integrations/boto3/_services/bedrock.py 85.00% 17/20 covered; missed: 19, 24, 29; partial branches: 18, 23, 28
sentry_sdk/integrations/boto3/_instrumentation.py 100.00% 9/9 covered; partial branches: 185, 189, 195
sentry_sdk/integrations/boto3/_client.py 100.00% 4/4 covered
sentry_sdk/integrations/boto3/_services/base.py 100.00% 1/1 covered
Coverage diff
@@            Coverage Diff             @@
##        master     #8226       +/-##
==========================================
- Coverage    90.35%    90.29%    -0.06%
==========================================
  Files          203       203         —
  Tracked lines     26931     26953       +22
  Branches     10058     10066        +8
==========================================
+ Hits         24331     24335        +4
- Misses        2600      2618       +18
- Partials      1517      1523        +6

Generated by Coverage Action

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d6cde74. Configure here.

@alexander-alderman-webb
alexander-alderman-webb marked this pull request as draft November 9, 2026 09:54
@alexander-alderman-webb
alexander-alderman-webb marked this pull request as ready for review November 9, 2026 10:04

@sentrivana sentrivana left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏻

@alexander-alderman-webb
alexander-alderman-webb merged commit da37f0a into master Nov 9, 2026
171 checks passed
@alexander-alderman-webb
alexander-alderman-webb deleted the webb/bedrock/skeleton branch November 9, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants