Repository navigation
fix(sampling): Respect incoming sample rate if not explicitly overridden - #8185
Merged
Merged
Conversation
Contributor
Coverage Results 📊✅ 137214 passed | ⏭️ 7456 skipped | Total: 144670 | Pass Rate: 94.85% | Execution Time: 442m 23s 📊 Comparison with Base Branch
✨ Test counts unchanged from base. All tests are passing successfully. ✅ Patch coverage is 100.00% (4 of 4 changed executable lines covered; target 80%). Changed files with executable lines (1)
Coverage diff@@ Coverage Diff @@
## master #8185 +/-##
==========================================
- Coverage 90.33% 90.32% -0.01%
==========================================
Files 203 203 —
Tracked lines 26905 26907 +2
Branches 10048 10048 —
==========================================
Hits 24302 24302 —
- Misses 2603 2605 +2
- Partials 1516 1518 +2Generated by Coverage Action |
sentrivana
force-pushed
the
ivana/preserve-incoming-sample-rate
branch
from
November 5, 2026 09:04
3a43948 to
8a5a066
Compare
sentrivana
marked this pull request as ready for review
November 5, 2026 09:19
alexander-alderman-webb
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If there's an incoming sampling decision,
traces_sample_rateis irrelevant and shouldn't overwrite the sampling rate in the DSC.There are cases where we do want to override the incoming sampling decision, but only in cases where the SDK actually uses a different sample rate for some reason (
traces_sampler).Issues
Closes #8182
Reminders
uv run ruff.feat:,fix:,ref:,meta:)